This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
[d3-sankey] Throw an error for graphs with cycles #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behaviour is to go into an infinite loop while trying to assign depths to nodes in case the graph has cycles. This commit changes it to explicitly throw an error instead till support for displaying cycles in sankeys is properly supported. Tested by modifying http://bost.ocks.org/mike/sankey/ data to have complex cycles and attempting to render.
|
This patch uses a hashtable to check if nodes have already been seen, and this uses the node name as a key. However, the node name is probably not necessarily unique. There is a similar situation in #105 (already merged), and there a list is used instead. Slower lookup, but proper node identity. |
|
(FYI: I started a friendly (subtree) fork (see #133) of the sankey plugin at https://github.com/soxofaan/d3-plugin-captain-sankey) This issue is handled by soxofaan/d3-plugin-captain-sankey#4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour is to go into an infinite loop while trying to
assign depths to nodes in case the graph has cycles. This commit changes
it to explicitly throw an error instead till displaying cycles in sankeys is properly
supported.
Tested by modifying http://bost.ocks.org/mike/sankey/ data to have
complex cycles and attempting to render.