The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

The process '/home/runner/.cargo/bin/cargo' failed with exit code 1

failed to resolve: could not find `ir` in `lcgs`

unresolved import `cgaal_engine::atl::convert`

unresolved import `cgaal_engine::game_structure::lcgs::parse`

this enum variant takes 1 argument but 2 arguments were supplied

this enum variant takes 1 argument but 2 arguments were supplied

this enum variant takes 1 argument but 2 arguments were supplied

this enum variant takes 1 argument but 2 arguments were supplied

this enum variant takes 1 argument but 2 arguments were supplied

this enum variant takes 1 argument but 2 arguments were supplied

this enum variant takes 1 argument but 2 arguments were supplied

failed to resolve: could not find `ir` in `lcgs`

failed to resolve: could not find `ir` in `lcgs`

failed to resolve: could not find `ir` in `lcgs`

unresolved import `crate::game_structure::lcgs::ast`

unresolved import `crate::game_structure::lcgs::parse`

failed to resolve: could not find `ir` in `lcgs`

unresolved import `crate::game_structure::lcgs::ast`

unresolved import `crate::game_structure::lcgs::parse`

cannot find function `parse_lcgs` in this scope

cannot find function `parse_lcgs` in this scope

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: the function `convert_expr_to_phi` doesn't need a mutable reference --> cgaal-cli/src/load.rs:110:66 | 110 | .and_then(|expr| convert_expr_to_phi(expr, game, &mut errors)) | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed

warning: the function `parse_atl` doesn't need a mutable reference --> cgaal-cli/src/load.rs:109:33 | 109 | parse_atl(&content, &mut errors) | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/parsing/mod.rs:15:1 | 15 | pub fn parse_atl(input: &str, errors: &ErrorLog) -> Result<Expr, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:327:80 | 327 | cases.push(RelabelCase::new(ident.span + expr.span, ident, expr.into())); | ^^^^^^^^^^^ help: consider removing `.into()`: `expr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:273:13 | 273 | update.into(), | ^^^^^^^^^^^^^ help: consider removing `.into()`: `update` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:271:13 | 271 | init.into(), | ^^^^^^^^^^^ help: consider removing `.into()`: `init` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:246:54 | 246 | Ok(RangeClause::new(start + end, min.into(), max.into())) | ^^^^^^^^^^ help: consider removing `.into()`: `max` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:246:42 | 246 | Ok(RangeClause::new(start + end, min.into(), max.into())) | ^^^^^^^^^^ help: consider removing `.into()`: `min` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: this `impl` can be derived --> cgaal-engine/src/game_structure/mod.rs:43:1 | 43 | / impl Default for StateIdx { 44 | | fn default() -> Self { 45 | | StateIdx(0) 46 | | } 47 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 19 + #[derive(Default)] 20 | pub struct $name(pub $typ); |

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/game_structure/lcgs/query.rs:7:1 | 7 | pub fn convert_expr_to_phi(expr: Expr, game: &IntermediateLcgs, errors: &ErrorLog) -> Result<Phi, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

warning: needlessly taken reference of left operand --> cgaal-engine/src/game_structure/lcgs/symbol_table.rs:103:32 | 103 | .find_map(|(i, s)| (&s.name == name).then_some(SymbIdx(i))) | ^-------^^^^^^^^^ | | | help: use the left value directly: `s.name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

warning: needlessly taken reference of left operand --> cgaal-engine/src/game_structure/lcgs/symbol_table.rs:91:16 | 91 | if &symb.name == name { | ----------^^^^^^^^ | | | help: use the left value directly: `symb.name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

warning: useless use of `format!` --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:524:21 | 524 | format!("Coalitions can only be used in ATL queries."), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Coalitions can only be used in ATL queries.".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:355:35 | 355 | return self.check(&con); | ^^^^ help: change this to: `con` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: unneeded `return` statement --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:375:17 | 375 | return Ok(Expr::new(*span, ExprKind::Symbol(index))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 375 - return Ok(Expr::new(*span, ExprKind::Symbol(index))); 375 + Ok(Expr::new(*span, ExprKind::Symbol(index))) |

warning: unneeded `return` statement --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:363:13 | 363 | return Ok(Expr::new(*span, ExprKind::Symbol(index))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 363 - return Ok(Expr::new(*span, ExprKind::Symbol(index))); 363 + Ok(Expr::new(*span, ExprKind::Symbol(index))) |

warning: useless use of `format!` --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:278:22 | 278 | msg: format!("Expression could not be reduced to a constant"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expression could not be reduced to a constant".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

warning: all variants have the same postfix: `Expr` --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:215:1 | 215 | / pub enum CheckMode { 216 | | /// In [ConstExpr] mode, identifiers in expressions can only refer to constants. 217 | | ConstExpr, 218 | | /// In [StateExpr] mode, identifiers in expressions can only refer to constants ... | 223 | | UpdateExpr, 224 | | } | |_^ | = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `#[warn(clippy::enum_variant_names)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:201:91 | 201 | SymbolChecker::new(symbols, &ident.owner, CheckMode::StateExpr).check(&cond)?; | ^^^^^ help: change this to: `cond` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: needlessly taken reference of both operands --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:190:20 | 190 | if &ident.name.text != &var.update_ident.text { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 190 | if ident.name.text != var.update_ident.text { | ~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:170:91 | 170 | SymbolChecker::new(symbols, &ident.owner, CheckMode::StateExpr).check(&expr)?; | ^^^^^ help: change this to: `expr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: unneeded `return` statement --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:28:5 | 28 | return Ok(out); | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 28 - return Ok(out); 28 + Ok(out) |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/relabeling.rs:184:37 | 184 | .map(|e| relabel_player(&self, e)) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:258:37 | 258 | next_state.0.insert(symb_id.clone(), val); | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*symb_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:245:32 | 245 | state.0.insert(action.clone(), 0); | ^^^^^^^^^^^^^^ help: try dereferencing it: `*action` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:216:57 | 216 | let value = Evaluator::new(&state).eval(&cond); | ^^^^^ help: change this to: `cond` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:157:30 | 157 | res.0.insert(symb_id.clone(), var.init_val); | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*symb_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:143:60 | 143 | return 0 != Evaluator::new(state).eval(&cond); | ^^^^^ help: change this to: `cond` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:107:28 | 107 | let label_symbol = self.labels[label_index.0].clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.labels[label_index.0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:95:32 | 95 | state.0.insert(symb_id.clone(), value); | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*symb_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: needlessly taken reference of both operands --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:74:26 | 74 | .find(|decl| &decl.ident.to_string() == &name) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default help: use the values directly | 74 | .find(|decl| decl.ident.to_string() == name) | ~~~~~~~~~~~~~~~~~~~~~~ ~~~~

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:64:35 | 64 | convert_expr_to_phi(expr, &self, errors) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:63:5 | 63 | pub fn create_phi(&self, expr: Expr, errors: &ErrorLog) -> Result<Phi, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:50:32 | 50 | } = symbol_check(root, &errors)?; | ^^^^^^^ help: change this to: `errors` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:44:5 | 44 | pub fn create(root: LcgsRoot, errors: &ErrorLog) -> Result<IntermediateLcgs, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err = note: `#[warn(clippy::result_unit_err)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs:40:47 | 40 | let decl = self.game.get_decl(&state_var).unwrap(); | ^^^^^^^^^^ help: change this to: `state_var` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_constrained_phi.rs:96:73 | 96 | let mapped_expr = Self::map_expr_to_constraints(&expr, negated); | ^^^^^ help: change this to: `expr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/instability_heuristic_search.rs:224:63 | 224 | InstabilityHeuristicSearch::bidist_of_expr(state, &expr) | ^^^^^ help: change this to: `expr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: redundant field names in struct initialization --> cgaal-engine/src/parsing/ast.rs:213:29 | 213 | OwnedIdent { owner, name: name } | ^^^^^^^^^^ help: replace it with: `name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

unused import: `crate::game_structure::GameStructure`

`cgaal-engine` (lib test) generated 1 warning

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

warning: the function `convert_expr_to_phi` doesn't need a mutable reference --> cgaal-cli/src/load.rs:110:66 | 110 | .and_then(|expr| convert_expr_to_phi(expr, game, &mut errors)) | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed

warning: the function `parse_atl` doesn't need a mutable reference --> cgaal-cli/src/load.rs:109:33 | 109 | parse_atl(&content, &mut errors) | ^^^^^^^^^^^ | = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed

warning: use of `unwrap_or` followed by a function call --> cgaal-engine/src/parsing/mod.rs:24:10 | 24 | .unwrap_or(Expr::new_error()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Expr::new_error())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/parsing/mod.rs:15:1 | 15 | pub fn parse_atl(input: &str, errors: &ErrorLog) -> Result<Expr, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:327:80 | 327 | cases.push(RelabelCase::new(ident.span + expr.span, ident, expr.into())); | ^^^^^^^^^^^ help: consider removing `.into()`: `expr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:273:13 | 273 | update.into(), | ^^^^^^^^^^^^^ help: consider removing `.into()`: `update` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:271:13 | 271 | init.into(), | ^^^^^^^^^^^ help: consider removing `.into()`: `init` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:246:54 | 246 | Ok(RangeClause::new(start + end, min.into(), max.into())) | ^^^^^^^^^^ help: consider removing `.into()`: `max` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: useless conversion to the same type: `parsing::ast::Expr` --> cgaal-engine/src/parsing/parser.rs:246:42 | 246 | Ok(RangeClause::new(start + end, min.into(), max.into())) | ^^^^^^^^^^ help: consider removing `.into()`: `min` | = note: `#[warn(clippy::useless_conversion)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

warning: this `impl` can be derived --> cgaal-engine/src/game_structure/mod.rs:43:1 | 43 | / impl Default for StateIdx { 44 | | fn default() -> Self { 45 | | StateIdx(0) 46 | | } 47 | | } | |_^ | = note: `#[warn(clippy::derivable_impls)]` on by default = help: try annotating `game_structure::StateIdx` with `#[derive(Default)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/game_structure/lcgs/query.rs:7:1 | 7 | pub fn convert_expr_to_phi(expr: Expr, game: &IntermediateLcgs, errors: &ErrorLog) -> Result<Phi, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

warning: needlessly taken reference of left operand --> cgaal-engine/src/game_structure/lcgs/symbol_table.rs:103:32 | 103 | .find_map(|(i, s)| (&s.name == name).then_some(SymbIdx(i))) | ^-------^^^^^^^^^ | | | help: use the left value directly: `s.name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

warning: needlessly taken reference of left operand --> cgaal-engine/src/game_structure/lcgs/symbol_table.rs:91:16 | 91 | if &symb.name == name { | ----------^^^^^^^^ | | | help: use the left value directly: `symb.name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

warning: useless use of `format!` --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:524:21 | 524 | format!("Coalitions can only be used in ATL queries."), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Coalitions can only be used in ATL queries.".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

warning: use of `ok_or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:508:18 | 508 | .ok_or(SpannedError::new( | __________________^ 509 | | id.span, 510 | | format!("Unknown player '{}'.", id.text), 511 | | ))?; | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 508 ~ .ok_or_else(|| SpannedError::new( 509 + id.span, 510 + format!("Unknown player '{}'.", id.text), 511 ~ ))?; |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:355:35 | 355 | return self.check(&con); | ^^^^ help: change this to: `con` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: use of `ok_or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:331:14 | 331 | .ok_or(SpannedError::new( | ______________^ 332 | | *span, 333 | | format!("Unknown declaration '{}'.", oi), 334 | | ))?; | |______________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 331 ~ .ok_or_else(|| SpannedError::new( 332 + *span, 333 + format!("Unknown declaration '{}'.", oi), 334 ~ ))?; |

warning: use of `ok_or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:317:18 | 317 | .ok_or(SpannedError::new( | __________________^ 318 | | player_name.span, 319 | | format!("Unknown player '{}'.", player_name.text), 320 | | ))?; | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call help: try this | 317 ~ .ok_or_else(|| SpannedError::new( 318 + player_name.span, 319 + format!("Unknown player '{}'.", player_name.text), 320 ~ ))?; |

warning: use of `or` followed by a function call --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:308:30 | 308 | oi.owner.clone().or(self.scope_owner.clone()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.scope_owner.clone())` | = note: `#[warn(clippy::or_fun_call)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call

warning: unneeded `return` statement --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:375:17 | 375 | return Ok(Expr::new(*span, ExprKind::Symbol(index))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(Expr::new(*span, ExprKind::Symbol(index)))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return

warning: unneeded `return` statement --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:363:13 | 363 | return Ok(Expr::new(*span, ExprKind::Symbol(index))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(Expr::new(*span, ExprKind::Symbol(index)))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return

warning: useless use of `format!` --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:278:22 | 278 | msg: format!("Expression could not be reduced to a constant"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expression could not be reduced to a constant".to_string()` | = note: `#[warn(clippy::useless_format)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

warning: all variants have the same postfix: `Expr` --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:215:1 | 215 | / pub enum CheckMode { 216 | | /// In [ConstExpr] mode, identifiers in expressions can only refer to constants. 217 | | ConstExpr, 218 | | /// In [StateExpr] mode, identifiers in expressions can only refer to constants ... | 223 | | UpdateExpr, 224 | | } | |_^ | = note: `#[warn(clippy::enum_variant_names)]` on by default = help: remove the postfixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:201:91 | 201 | SymbolChecker::new(symbols, &ident.owner, CheckMode::StateExpr).check(&cond)?; | ^^^^^ help: change this to: `cond` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: needlessly taken reference of both operands --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:190:20 | 190 | if &ident.name.text != &var.update_ident.text { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 190 | if ident.name.text != var.update_ident.text { | ~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:170:91 | 170 | SymbolChecker::new(symbols, &ident.owner, CheckMode::StateExpr).check(&expr)?; | ^^^^^ help: change this to: `expr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: unneeded `return` statement --> cgaal-engine/src/game_structure/lcgs/symbol_checker.rs:28:5 | 28 | return Ok(out); | ^^^^^^^^^^^^^^^ help: remove `return`: `Ok(out)` | = note: `#[warn(clippy::needless_return)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/relabeling.rs:184:37 | 184 | .map(|e| relabel_player(&self, e)) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `game_structure::lcgs::symbol_table::SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:258:37 | 258 | next_state.0.insert(symb_id.clone(), val); | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*symb_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `game_structure::lcgs::symbol_table::SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:245:32 | 245 | state.0.insert(action.clone(), 0); | ^^^^^^^^^^^^^^ help: try dereferencing it: `*action` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:216:57 | 216 | let value = Evaluator::new(&state).eval(&cond); | ^^^^^ help: change this to: `cond` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `game_structure::lcgs::symbol_table::SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:157:30 | 157 | res.0.insert(symb_id.clone(), var.init_val); | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*symb_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:143:60 | 143 | return 0 != Evaluator::new(state).eval(&cond); | ^^^^^ help: change this to: `cond` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: using `clone` on type `game_structure::lcgs::symbol_table::SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:107:28 | 107 | let label_symbol = self.labels[label_index.0].clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.labels[label_index.0]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: using `clone` on type `game_structure::lcgs::symbol_table::SymbIdx` which implements the `Copy` trait --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:95:32 | 95 | state.0.insert(symb_id.clone(), value); | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*symb_id` | = note: `#[warn(clippy::clone_on_copy)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

warning: needlessly taken reference of both operands --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:74:26 | 74 | .find(|decl| &decl.ident.to_string() == &name) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::op_ref)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 74 | .find(|decl| decl.ident.to_string() == name) | ~~~~~~~~~~~~~~~~~~~~~~ ~~~~

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:64:35 | 64 | convert_expr_to_phi(expr, &self, errors) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:63:5 | 63 | pub fn create_phi(&self, expr: Expr, errors: &ErrorLog) -> Result<Phi, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:50:32 | 50 | } = symbol_check(root, &errors)?; | ^^^^^^^ help: change this to: `errors` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this returns a `Result<_, ()>` --> cgaal-engine/src/game_structure/lcgs/intermediate.rs:44:5 | 44 | pub fn create(root: LcgsRoot, errors: &ErrorLog) -> Result<IntermediateLcgs, ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(clippy::result_unit_err)]` on by default = help: use a custom `Error` type instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs:124:58 | 124 | dist += (state.0[&state_var] - rep.0[&state_var]).unsigned_abs(); | ^^^^^^^^^^ help: change this to: `state_var` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs:124:38 | 124 | dist += (state.0[&state_var] - rep.0[&state_var]).unsigned_abs(); | ^^^^^^^^^^ help: change this to: `state_var` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_representative_search.rs:40:47 | 40 | let decl = self.game.get_decl(&state_var).unwrap(); | ^^^^^^^^^^ help: change this to: `state_var` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/linear_constrained_phi.rs:96:73 | 96 | let mapped_expr = Self::map_expr_to_constraints(&expr, negated); | ^^^^^ help: change this to: `expr` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cgaal-engine/src/algorithms/certain_zero/search_strategy/instability_heuristic_search.rs:224:63 | 224 | InstabilityHeuristicSearch::bidist_of_expr(state, &expr) | ^^^^^ help: change this to: `expr` | = note: `#[warn(clippy::needless_borrow)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: redundant field names in struct initialization --> cgaal-engine/src/parsing/ast.rs:213:29 | 213 | OwnedIdent { owner, name: name } | ^^^^^^^^^^ help: replace it with: `name` | = note: `#[warn(clippy::redundant_field_names)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/