Sort cities according to the normalization function used when searching #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A binary search is used to find the city specified with -i/--city.
Therefore, the cities array must be sorted accordingly to the comparison
function used in the binary search.
The currently used comparison function normalizes city names. In
particular, all names are lowercased, which impacts their
lexicographical order.
Because of this, the following example fails without this patch, even
though "Rio de Janeiro" is in data/cities.csv.
$ astroterm -mi "Rio de Janeiro"
ERROR: Could not find city "Rio de Janeiro"
To fix it, use the normalized city names when sorting them in
filter_cities.py. The normalization should match the one used at
runtime. Then regenerate data/cities.csv with:
$ python scripts/filter_cities.py cities15000.txt data/cities.csv 200000
(cities15000.txt downloaded today from: https://download.geonames.org/export/dump/cities15000.zip)
da-luce
added a commit
that referenced
this pull request
Jul 14, 2025
|
Nice catch - thanks @jonasmalacofilho! |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A binary search is used to find the city specified with
-i/--city. Therefore, the cities array must be sorted according to the comparison function used in the binary search.The currently used comparison function normalizes city names. In particular, all names are lowercased, which impacts their lexicographical order.
Because of this, the following example fails without this patch, even though "Rio de Janeiro" is in
data/cities.csv.To fix it, use the normalized city names when sorting them in
filter_cities.py. The normalization should match the one used at runtime. Then regeneratedata/cities.csvwith:(
cities15000.txtdownloaded today from: https://download.geonames.org/export/dump/cities15000.zip)