Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Solid integration #473

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Jul 4, 2024

Related: #277

Tasks

  • Port integration
  • Port plugin-renderer-basic
  • Port plugin-renderer-web
  • Port plugin-basic-ui
  • Port demo app
  • Port plugin-history-sync
    • Fix broken typecheck when skipLibCheck: false and either @stackflow/react or @stackflow/solid is missing
  • Port plugin-map-initial-activity the implementation was actually not React-specific at all
  • Port plugin-preload
  • Port link
  • Port plugin-google-analytics-4 I'll skip this for now. I actually have no idea what react-ga4 offers in addition to raw GA features
  • Update docs I'll do this on a followup PR
  • Port future APIs

All concerns mentioned in the comment should be resolved before merging.

Future works

  • Add SolidStart filesystem router integration

Copy link

changeset-bot bot commented Jul 4, 2024

⚠️ No Changeset found

Latest commit: 4c12797

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Nov 22, 2024 7:31am

@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from da1f6f1 to a4ea37c Compare July 6, 2024 06:46
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from a4ea37c to 7a9a851 Compare July 6, 2024 07:30
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from d999211 to 30c6542 Compare July 6, 2024 08:53
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 30c6542 to 79bea8d Compare July 7, 2024 10:04
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 79bea8d to 006f218 Compare July 7, 2024 11:55
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 006f218 to ae74f20 Compare July 7, 2024 12:31
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from ae74f20 to 5f6b424 Compare July 7, 2024 12:41
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 5f6b424 to 835e921 Compare July 7, 2024 15:03
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 835e921 to 8f791ae Compare July 7, 2024 15:17
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 8f791ae to 7173796 Compare July 7, 2024 15:25
@tonyfromundefined tonyfromundefined requested review from tonyfromundefined and orionmiz and removed request for tonyfromundefined July 8, 2024 05:55
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 7173796 to 1e666e4 Compare July 8, 2024 16:32
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 2fc968e to 170a3e1 Compare August 21, 2024 14:04
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 170a3e1 to b13619d Compare August 30, 2024 02:47
@XiNiHa XiNiHa mentioned this pull request Oct 4, 2024
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from b13619d to a0419d4 Compare October 11, 2024 09:40
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from a0419d4 to abab2fd Compare October 11, 2024 09:52
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from abab2fd to 18f04b0 Compare October 11, 2024 09:54
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 0a3972b to 6802e68 Compare October 11, 2024 10:12
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 6802e68 to abf74d3 Compare October 11, 2024 10:23
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from abf74d3 to 3b535d6 Compare November 4, 2024 06:43
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 3b535d6 to 135f709 Compare November 4, 2024 06:57
@XiNiHa XiNiHa force-pushed the feat/solid-integration branch from 854bbd7 to 4c12797 Compare November 22, 2024 07:25
@XiNiHa XiNiHa marked this pull request as ready for review November 22, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant