Skip to content

Conversation

ReenigneArcher
Copy link
Contributor

@ReenigneArcher ReenigneArcher commented Dec 20, 2024

This PR adds some missing giscus attributes. I assume these were not available when giscus was added originally.

Additionally, there is a logic change that allows a local css file for the giscus theme. I tried to test this locally and it requires CORS to be disabled, I am not sure how this would work on a GitHub hosted site, but in any event it allows to specify a theme like /assets/css/giscus.css or any local path that starts with /. Normally giscus will try to get any non full url theme from their own server/api.

https://giscus.app/

Here is a screenshot of evidence of the a custom theme css working for giscus.
image

@ReenigneArcher ReenigneArcher force-pushed the fix/giscus/add-missing-attributes branch from fdc8c2a to 92a2e6b Compare December 20, 2024 01:46
@ReenigneArcher ReenigneArcher changed the title fix(giscus): add missing attributes fix(giscus): add missing attributes and allow local theme Dec 20, 2024
Copy link

@ahmadwardat ahmadwardat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants