Rewrite router using starlette #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to configure this. I might submit a PR for it
It's a nice touch
This saves TCP connection times, and allows connection pooling.
j4mie
reviewed
Dec 17, 2019
router.py
Outdated
| HEADERS_TO_STRIP = ["server", "date"] | ||
|
|
||
|
|
||
| client = httpx.AsyncClient() |
There was a problem hiding this comment.
httpx's default timeout is 5 seconds. Need to use timeout=None i think.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5
Features:
asyncio-based, so has higher throughput, and doesn't get locked down when more than 4 requests come in at onceserver: crabheaderuvicorn, a production-grade server, rather than a dev server