Shift limit - fixes issue #52 #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinr3
force-pushed
the
shift-limit
branch
from
d269e80 to
23f8ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@j4mie, Further to previous discussion, here is a proposed solution to #52 that optionally limits the processing time of a worker process. I've tried to keep it simple and, hopefully, not introduce a significant maintenance overhead.
I've updated the README and added some tests that illustrate how it would work in conjunction with
--rate_limit. Let me know if I've missed anything.I'd also welcome your feedback on the approach.