Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build workflow #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add build workflow #446

wants to merge 1 commit into from

Conversation

sebastienros
Copy link
Contributor

This creates the build workflow which is triggered on new PRs targeting master and when a commit is done on `master.

It also has a workflow for publishing the packages but it's not final. This can be tested freely as it's not publishing the packages it builds but still assigns then as artifacts to be able to look at the results. It's using the va.b.c tag to set the version, but this can be removed to reuse the current logic (defined in source).

@sebastienros
Copy link
Contributor Author

Once merged, to setup, in Settings, Branches, Branch protection rules, add for master then check "Require status checks to pass before merging", select "build" (the name of the workflow in the yml). It may only appear after it's run at least once (a commit on master should trigger it automatically).

@sebastienros
Copy link
Contributor Author

In terms of speed you should notice that the GH actions are started much quicker than appveyor. And should also run faster.

@sebastienros
Copy link
Contributor Author

CI fails on appveyor because this PR is adding a global.json that enforces users have .NET 9.0 (I assume it's required to build this repos, right?)

@dadhi
Copy link
Owner

dadhi commented Dec 23, 2024

@sebastienros By users you mean contributors? If so then yes.
For the clients it multitargets to net472;netstandard2.0;netstandard2.1;net6.0;net8.0;net9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants