Add fast pytest for skpro FunctionalCPD in FunctionalBN refactor#61
Merged
Add fast pytest for skpro FunctionalCPD in FunctionalBN refactor#61
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new test case, test_fit_with_bayesian_linear_regressor_uses_fast_mocked_fit, to verify the integration of FunctionalBayesianNetwork with skpro's BayesianLinearRegressor using a mocked fit method. The review feedback recommends using monkeypatch.setitem when modifying the _tags attribute of BayesianLinearRegressor to prevent side effects from persisting across other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
skprointegration path inFunctionalCPDwithout running expensive Bayesian training.FunctionalBayesianNetworkcorrectly invokes the external-model adapter fortag='skpro'and passes the expected input shapes.Description
pytestimport and a new testtest_fit_with_bayesian_linear_regressor_uses_fast_mocked_fittopgmpy/tests/test_models/test_FunctionalBayesianNetwork_Refactor.pythat exercises theskproCPD path with a small synthetic dataset.pytest.importorskipforskproandpymc_marketingandmonkeypatchto replaceBayesianLinearRegressor.fitwith a fast mock that recordsX/yshapes and column names.FunctionalBNwith mixed CPD tags (tabular,skpro,linear), callsmodel.fit(data), and asserts the adapter supplied a constant-design matrix (['_const_']) of shape(n_samples, 1)and the expectedyshape.Testing
pytest -q pgmpy/tests/test_models/test_FunctionalBayesianNetwork_Refactor.pywhich completed with2 passed, 1 skipped.pre-commit run --all-filesbut it failed in the environment withpre-commit: command not found.Codex Task