Move to rank internals #174
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- utility to rank - preference to rank
* Write init test for new single matching * Move to ruff over black for formatting * Remove limit on parallel CI * Write test for SingleMatching repr dunder method * Check dictionary is in single matching repr * Write test for equivalence dunder * Write test for single matching inverter * Remove old SingleMatching tests * Implement SingleMatching class * Move matching classes to subpackage * Write test for instantiating SM classes * Fix ruff config and add pre-commit * Write tests for utility builder * Write test for preference list builder (slow!) * Reduce test size for preference builder * Implement builders for SM * Write input validator tests * Implement input validator * Ensure higher utility leads to higher ranking * Reintegrate tests into modular structure * Translate SM algorithm test to rankings * Write test for player set attribute inverter * Move rank matrices to class attributes * Write tests for solver * Implement solver and algorithm * Rewrite preference converter test * Write test for converting incomplete preferences * Reimplement preference converter * Include preference lookup in attributes * Write optimality tests * Rewrite example tests * Ensure rejections are recorded * Write test for preference matching converter * Revert example tests to use preference terms * Implement a preference matching converter * Reformat code base and drop deprecated np.infty * Bump actions and drop support for Python<3.10 * Stop doctesting paper and fix examples in README * Update all docs that SM touches * Remove creation from instances how-to * Remove SM solver test module * Wrap SR tutorial solution with `dict()` for now The changes to `SingleMatching` are causing issues downstream. Still not sure what this will look like for SR in the future, but this will do for now. * Make small formatting changes * Add in manual matching update for SR test Again, the new `SingleMatching` class is causing issues for SR... * Remove change to SM discussion * Stop rejections leading to immediate forget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins the process of closing #153.
This PR is the staging point for a few more to come prior to merging into
dev-2.0.0. Each subsequent PR will implement these rank matrix changes to the problems implemented inmatching.