Skip to content

Fix bad stringification of negative years #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LouisStrous wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bad stringification of negative years #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26fad52
Add test case to show that negative years aren't stringified correctly
Oct 11, 2025
9013f8c
Make Date::Tiny instances with negative years be stringified correctly
Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Date/Tiny.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ format, which returns in the form "2006-04-12".
=cut

sub ymd {
sprintf( "%04u-%02u-%02u",
sprintf( "%04.4d-%02u-%02u",
$_[0]->year,
$_[0]->month,
$_[0]->day,
Expand Down
20 changes: 19 additions & 1 deletion t/02_main.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ BEGIN {
$^W = 1;
}

use Test::More tests => 19;
use Test::More tests => 21;
use Date::Tiny;


Expand Down Expand Up @@ -80,3 +80,21 @@ SCOPE: {
is( $date->month, 1, '->month ok' );
is( $date->day, 31, '->day ok' );
}

# Testing stringification

SCOPE: {
my $date = Date::Tiny->new(
year => 6,
month => 1,
day => 31
);
is( "$date", '0006-01-31', 'stringification positive year ok' );

$date = Date::Tiny->new(
year => -3,
month => 7,
day => 5
);
is( "$date", '-0003-07-05', 'stringification negative year ok' );
}