Skip to content

Fix slurp_raw for files larger than 2GB #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igor-raits wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix slurp_raw for files larger than 2GB #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions lib/Path/Tiny.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2094,11 +2094,20 @@ sub slurp {
my $binmode = $args->{binmode};
$binmode = ( ( caller(0) )[10] || {} )->{'open<'} unless defined $binmode;
my $fh = $self->filehandle( { locked => 1 }, "<", $binmode );
if ( ( defined($binmode) ? $binmode : "" ) eq ":unix"
and my $size = -s $fh )
if ( defined($binmode) and $binmode eq ":unix"
and my $total_left = -s $fh )
{
my $buf;
my $rc = read $fh, $buf, $size; # File::Slurp in a nutshell
# Read in a loop to handle read() syscall size limit (~2GB)
my $buf = "";
my $total_read = 0;
my $rc = 0;
while ( $rc = read $fh, $buf, $total_left, $total_read ) {
$total_read += $rc;
# Ensure we will keep read()ing until we get 0 or undef
# even if someone else changed the file length from under us
$total_left = ( -s $fh ) - $total_read;
$total_left = 1 if $total_left < 1;
}
$self->_throw('read') unless defined $rc;
return $buf;
}
Expand Down Expand Up @@ -2178,7 +2187,22 @@ sub spew {
: "error opening temp file for atomic write: $@";
$self->_throw('spew', $self->[PATH], $msg);
}
print( {$fh} map { ref eq 'ARRAY' ? @$_ : $_ } @data) or $self->_throw('print', $temp->[PATH]);
if ( defined($binmode) and $binmode eq ":unix" ) {
# Use syswrite in a loop to handle write() syscall size limit (~2GB)
for my $data ( map { ref eq 'ARRAY' ? @$_ : $_ } @data ) {
my $total_left = length $data;
my $total_written = 0;
my $rc = 0;
while ( $total_left and ( $rc = syswrite $fh, $data, $total_left, $total_written ) ) {
$total_left -= $rc;
$total_written += $rc;
}
$self->_throw('syswrite', $temp->[PATH]) unless defined $rc;
}
}
else {
print( {$fh} map { ref eq 'ARRAY' ? @$_ : $_ } @data) or $self->_throw('print', $temp->[PATH]);
}
close $fh or $self->_throw( 'close', $temp->[PATH] );

return $temp->move($resolved_path);
Expand Down