Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove vestigial T_Handle #22772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove vestigial T_Handle #22772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions python_modules/dagster/dagster/_core/definitions/graph_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,8 +466,6 @@ def get_output_mapping(self, output_name: str) -> OutputMapping:
return mapping
check.failed(f"Could not find output mapping {output_name}")

T_Handle = TypeVar("T_Handle", bound=Optional[NodeHandle])

def resolve_output_to_origin(
self, output_name: str, handle: Optional[NodeHandle]
) -> Tuple[OutputDefinition, Optional[NodeHandle]]:
Expand Down
7 changes: 2 additions & 5 deletions python_modules/dagster/dagster/_core/definitions/op_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
Optional,
Sequence,
Tuple,
TypeVar,
Union,
cast,
)
Expand Down Expand Up @@ -323,11 +322,9 @@ def iterate_node_defs(self) -> Iterator[NodeDefinition]:
def iterate_op_defs(self) -> Iterator["OpDefinition"]:
yield self

T_Handle = TypeVar("T_Handle", bound=Optional[NodeHandle])

def resolve_output_to_origin(
self, output_name: str, handle: T_Handle
) -> Tuple[OutputDefinition, T_Handle]:
self, output_name: str, handle: Optional[NodeHandle]
) -> Tuple[OutputDefinition, Optional[NodeHandle]]:
return self.output_def_named(output_name), handle

def resolve_output_to_origin_op_def(self, output_name: str) -> "OpDefinition":
Expand Down