split out pool detailed info into a standalone settings page by prha · Pull Request #26805 · dagster-io/dagster

prha · 2025-01-03T05:19:17Z

Summary & Motivation

With #26804, we're directing more attention to the settings for specific pools.

This PR creates a new dedicated view for specific pool information (was previously in a dialog).

Screen.Recording.2025-01-23.at.11.16.45.AM.mov

How I Tested These Changes

BK

Changelog

Creates a standalone view for specific pool info

prha · 2025-01-03T05:19:30Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-01-03T05:31:15Z

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-o2bou273d-elementl.vercel.app
https://prha-ui-instance-page.core-storybook.dagster-docs.io

Built with commit bec08b1.
This pull request is being automatically deployed with vercel-action

vercel · 2025-01-20T00:28:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dagster-docs-legacy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 20, 2025 0:52am

hellendag

Can you include a few screenshots?

hellendag · 2025-01-22T19:43:25Z

              key={item.key}
              item={item}
-              active={item.type === 'link' && pathname === item.path}
+              active={item.type === 'link' && pathname.startsWith(item.path)}


Is this necessary?

I wanted the Concurrency tab to selected when viewing the detailed page. The link item maps to the index page (without the specific key path).

hellendag · 2025-01-22T19:45:14Z

          <InstanceHealthPageContent />
        </Route>
-        <Route path="/deployment/concurrency">
+        <Route path="/deployment/concurrency(/?.*)">


Could this be /deployment/concurrency/:concurrencyKey?? Or is the concurrencyKey value too complex for this?

I wanted the URL to match both the top-level /deployment/concurrency url as well as the detailed pool-specific /deployment/concurrency/foo url.

I was thinking that using :concurrencyKey? (with the ?) would allow this, but off the top of my head I don't remember whether that's the way to do that with react-router.

oh, you're right, that does work

hellendag · 2025-01-22T19:46:44Z

+            >
+              <Subheading>In progress</Subheading>
+            </Box>
+            <Box style={{marginLeft: -1}}>


What does it look like without these?

There's a left-border for all the table rows, so it looks like an extra thick border. I couldn't figure out how to disable that, so I just cheated 😭

Yeah, I guess we have that elsewhere too. Oh well. Probably worth it for me to go in and fix these.

Could have sworn we had resolved that in some way at some point, since all of our tables tend to be full-width...

hellendag · 2025-01-22T19:48:02Z

+  if (String(value) !== concurrencyLimit.trim()) {
+    return false;
+  }


What's the specific case here?

I think if you tried to do some sort of decimal:

const valueStr = "1.3"; const value = parseInt(valueStr); // evaluates to 1

I think if you use type="number" on the input, it won't allow a decimal to be entered since the default stepping value is 1 and input is therefore restricted to integers.

hellendag · 2025-01-23T20:13:29Z

          <InstanceHealthPageContent />
        </Route>
-        <Route path="/deployment/concurrency">
+        <Route path="/deployment/concurrency(/?.*)">


I was thinking that using :concurrencyKey? (with the ?) would allow this, but off the top of my head I don't remember whether that's the way to do that with react-router.

hellendag · 2025-01-23T20:17:03Z

+            >
+              <Subheading>In progress</Subheading>
+            </Box>
+            <Box style={{marginLeft: -1}}>


Yeah, I guess we have that elsewhere too. Oh well. Probably worth it for me to go in and fix these.

Could have sworn we had resolved that in some way at some point, since all of our tables tend to be full-width...

hellendag · 2025-01-23T20:17:33Z

+              <Heading>
+                <Box flex={{direction: 'row', gap: 8, alignItems: 'center'}}>
+                  <div>
+                    <Link to="/deployment/concurrency">
+                      {flagPoolUI ? 'Pools' : 'Concurrency keys'}
+                    </Link>
+                  </div>
+                  <div>/</div>
+                  <div>{concurrencyKey}</div>
+                </Box>
+              </Heading>


From the screenshot, this heading section looks like it needs a bottom border.

hellendag · 2025-01-23T20:18:28Z

+  if (String(value) !== concurrencyLimit.trim()) {
+    return false;
+  }


I think if you use type="number" on the input, it won't allow a decimal to be entered since the default stepping value is 1 and input is therefore restricted to integers.

This was referenced Jan 3, 2025

thread pool info to remote representation of assets #26801

Merged

thread pool information to graphql layer #26802

Merged

separate configured limit from slot count #26803

Merged

add pool tag to display for ops / assets #26804

Merged

prha force-pushed the prha/ui_pool_reference branch from 18c1cfc to c01da8d Compare January 6, 2025 20:04

prha force-pushed the prha/ui_instance_page branch from c5aaa65 to d269905 Compare January 6, 2025 20:04

prha force-pushed the prha/ui_pool_reference branch from c01da8d to 15bc61b Compare January 6, 2025 20:52

prha force-pushed the prha/ui_instance_page branch from d269905 to 05cbe94 Compare January 6, 2025 20:52

prha force-pushed the prha/ui_pool_reference branch from 15bc61b to 81fd01b Compare January 6, 2025 22:06

prha force-pushed the prha/ui_instance_page branch from 05cbe94 to f508458 Compare January 6, 2025 22:06

prha force-pushed the prha/ui_pool_reference branch from 81fd01b to 948ce8f Compare January 7, 2025 17:17

prha force-pushed the prha/ui_instance_page branch from f508458 to 36ef1c1 Compare January 7, 2025 17:17

prha force-pushed the prha/ui_pool_reference branch from 948ce8f to e95b257 Compare January 7, 2025 18:54

prha force-pushed the prha/ui_instance_page branch from 36ef1c1 to 4eb991b Compare January 7, 2025 18:54

prha force-pushed the prha/ui_pool_reference branch from e95b257 to 02311b6 Compare January 7, 2025 22:53

prha force-pushed the prha/ui_instance_page branch from 4eb991b to b50b563 Compare January 7, 2025 22:54

prha force-pushed the prha/ui_pool_reference branch from 02311b6 to fd552b6 Compare January 8, 2025 04:25

prha force-pushed the prha/ui_instance_page branch from b50b563 to 53edb22 Compare January 8, 2025 04:25

prha force-pushed the prha/ui_pool_reference branch from fd552b6 to f1ee75f Compare January 8, 2025 04:49

prha force-pushed the prha/ui_instance_page branch 2 times, most recently from 87c0a6f to d24cf46 Compare January 8, 2025 04:59

prha force-pushed the prha/ui_pool_reference branch from f1ee75f to 3c5deda Compare January 8, 2025 05:13

prha force-pushed the prha/ui_instance_page branch from d24cf46 to 80d3b13 Compare January 8, 2025 05:13

prha force-pushed the prha/ui_pool_reference branch from 3c5deda to 9fa4539 Compare January 8, 2025 05:17

prha force-pushed the prha/ui_instance_page branch 2 times, most recently from c3e9fa3 to 7d4debd Compare January 8, 2025 05:26

prha force-pushed the prha/ui_pool_reference branch from 9fa4539 to 16f3f44 Compare January 8, 2025 19:52

prha force-pushed the prha/ui_instance_page branch from 7d4debd to 7903c5f Compare January 8, 2025 19:52

prha force-pushed the prha/ui_instance_page branch from 47d228f to 0af051b Compare January 17, 2025 02:27

prha force-pushed the prha/ui_pool_reference branch from fefe7fa to fda08ba Compare January 17, 2025 02:54

prha force-pushed the prha/ui_instance_page branch from 0af051b to d199ebd Compare January 17, 2025 02:55

prha force-pushed the prha/ui_pool_reference branch 2 times, most recently from 39f76f5 to dd164aa Compare January 20, 2025 00:28

prha mentioned this pull request Jan 20, 2025

Allow concurrency limits to handle changing the default limit #27112

Merged

prha force-pushed the prha/ui_instance_page branch from d199ebd to 8c0784c Compare January 20, 2025 00:28

prha changed the base branch from prha/ui_pool_reference to prha/run_pools_ui January 20, 2025 00:28

vercel Bot deployed to Preview January 20, 2025 00:52 View deployment

prha force-pushed the prha/run_pools_ui branch from 3e86416 to 3f350c4 Compare January 21, 2025 17:58

prha force-pushed the prha/ui_instance_page branch from 8c0784c to f9a9f32 Compare January 21, 2025 17:58

prha force-pushed the prha/run_pools_ui branch 2 times, most recently from 44a9628 to 30ce73f Compare January 22, 2025 01:58

prha force-pushed the prha/ui_instance_page branch from f9a9f32 to c72a8e6 Compare January 22, 2025 01:58

prha force-pushed the prha/run_pools_ui branch from 30ce73f to 49a6f83 Compare January 22, 2025 19:04

prha force-pushed the prha/ui_instance_page branch from c72a8e6 to 7b80a1d Compare January 22, 2025 19:05

prha force-pushed the prha/run_pools_ui branch from 49a6f83 to 9f644f3 Compare January 22, 2025 19:26

prha force-pushed the prha/ui_instance_page branch from 7b80a1d to 1ed7d4d Compare January 22, 2025 19:26

prha requested review from bengotow and hellendag and removed request for hellendag January 22, 2025 19:31

hellendag reviewed Jan 22, 2025

View reviewed changes

prha force-pushed the prha/run_pools_ui branch from 9f644f3 to 9c9353d Compare January 22, 2025 21:11

prha force-pushed the prha/ui_instance_page branch from 1ed7d4d to 47a0fa5 Compare January 22, 2025 21:11

bengotow approved these changes Jan 23, 2025

View reviewed changes

Comment thread js_modules/dagster-ui/packages/ui-core/src/instance/VirtualizedInstanceConcurrencyTable.tsx Outdated

hellendag approved these changes Jan 23, 2025

View reviewed changes

prha added 2 commits January 31, 2025 12:58

standalone concurrency page

18ab52f

add run granularity keys

bec08b1

Conversation

prha commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary & Motivation

How I Tested These Changes

Changelog

Uh oh!

prha commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hellendag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

prha commented Jan 3, 2025 •

edited

Loading

prha commented Jan 3, 2025 •

edited

Loading

github-actions Bot commented Jan 3, 2025 •

edited

Loading

vercel Bot commented Jan 20, 2025 •

edited

Loading