Conversation
Contributor
Author
|
Sorry... I need to download your latest changes first |
Owner
|
hi @felipealbuquerq |
Contributor
Author
|
Hi @dahfazz! I will fork my personal GitHub later and adjust it 👍 |
dahfazz
requested changes
Oct 31, 2020
Owner
dahfazz
left a comment
dahfazz
left a comment
There was a problem hiding this comment.
please remove /dist folder from git files
the folder will be generated when building app
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "$schema": "./node_modules/ng-packagr/package.schema.json", | |||
| "name": "@thinkam.net/ng-cast", | |||
Contributor
Author
|
Done! |
dahfazz
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes it will be easier to improve the package