compress Slice when create filemetadata #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran into similar issue. Did some digging. The root cause is that start and end key maintained per file in FileMetadata are pinning down the entire buffer storing entire key-value. In other words, if the key+val is 10MB, FileMetadata's start/end key references a slice of this 10MB and ends up preventing freeing the buffer. |
|
My proposed fix is in this PR: #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when DbImpl used as singleton bean in spring application context for a long time, the oom ex occured
after inspect the heap dump file
i found the actually length of filemetadata.largest.userKey is 33, while size of filemetadata.largest.userKey.data is 10485kb