-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create the join or discord and other social links section (WEB-34) #83
chore: create the join or discord and other social links section (WEB-34) #83
Conversation
src/app/page.tsx
Outdated
discordUrl: '/', | ||
linkedinUrl: '/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure of the links for Discord and LinkedIn but can update once confirmed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked in: https://www.linkedin.com/company/dallas-software-developers
GitHub: https://github.com/dallassoftwaredevelopers
Meetup: https://www.meetup.com/dallas-software-developers-meetup/
Let me get back to you for the discord
{links.map((link) => ( | ||
<li key={link.id}> | ||
<a href={link.link} target='_blank'> | ||
<Image src={link.imgSrc} alt={link.alt} width={100} height={100} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious for thoughts on using React icons in place of the static images. This could give more control over the base and hover colors of the icons and give more consistency across all the social icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Can you proceed to tackle this?
} | ||
|
||
.socialSection p { | ||
font-family: 'Raleway', sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this could be defined using CSS variables, along with other global styles like specific theme colors, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great idea. Lets create another ticket for adding global css variables to tackle consistency across the web app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some comments to your questions please review when you have a moment and thank you for your contributions.
5d76c2d
into
dallassoftwaredevelopers:main
This adds the Discord and social links section to site:
To build this out, the following components were created:
SocialSection
- container for section and media + copySocialLinks
- renders social icon images and associated linksBased on Figma, it appears this section is hidden in the mobile view so conditional rendering is set for the component.
Resolves issue #72