Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create the join or discord and other social links section (WEB-34) #83

Merged

Conversation

tk1ng
Copy link
Contributor

@tk1ng tk1ng commented Apr 11, 2024

This adds the Discord and social links section to site:

CleanShot 2024-04-11 at 01 53 48@2x

To build this out, the following components were created:

SocialSection - container for section and media + copy

SocialLinks - renders social icon images and associated links

Based on Figma, it appears this section is hidden in the mobile view so conditional rendering is set for the component.

Resolves issue #72

@tk1ng tk1ng changed the title chore: create the join or discord and other social links section (WEB-34) #72 chore: create the join or discord and other social links section (WEB-34) Apr 11, 2024
src/app/page.tsx Outdated
Comment on lines 41 to 42
discordUrl: '/',
linkedinUrl: '/',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure of the links for Discord and LinkedIn but can update once confirmed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{links.map((link) => (
<li key={link.id}>
<a href={link.link} target='_blank'>
<Image src={link.imgSrc} alt={link.alt} width={100} height={100} />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious for thoughts on using React icons in place of the static images. This could give more control over the base and hover colors of the icons and give more consistency across all the social icons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Can you proceed to tackle this?

}

.socialSection p {
font-family: 'Raleway', sans-serif;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking this could be defined using CSS variables, along with other global styles like specific theme colors, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea. Lets create another ticket for adding global css variables to tackle consistency across the web app.

Copy link
Contributor

@GetBlackBoxSolutions GetBlackBoxSolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments to your questions please review when you have a moment and thank you for your contributions.

@GetBlackBoxSolutions GetBlackBoxSolutions merged commit 5d76c2d into dallassoftwaredevelopers:main Apr 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants