Skip to content

🧹 Fix ignored error for DataUsageInfo in BucketsHandler#62

Merged
damacus merged 1 commit into
mainfrom
fix/data-usage-error-handling-9830336635236494968
May 12, 2026
Merged

🧹 Fix ignored error for DataUsageInfo in BucketsHandler#62
damacus merged 1 commit into
mainfrom
fix/data-usage-error-handling-9830336635236494968

Conversation

@damacus
Copy link
Copy Markdown
Owner

@damacus damacus commented May 11, 2026

🎯 What: Handled the previously ignored error from mdm.DataUsageInfo(c.Request().Context()) in internal/handlers/buckets_handler.go.
💡 Why: Silently ignoring errors is poor practice. Logging the error improves visibility and helps debugging when users lack sufficient admin permissions to fetch data usage. Since the code handles a nil or empty BucketSizes properly when falling back to 0, it's safer to just log this specific error rather than throw an HTTP 500 block for users who only have bucket listing permissions, not global permissions.
Verification: Ran go test ./... in the background utilizing automatic downloading, ensuring existing functionality tests pass. Verified the refactored chunk avoids shadowing scope and continues execution when the error triggers.
Result: Better error visibility, improved maintainability of the handlers package.


PR created automatically by Jules for task 9830336635236494968 started by @damacus

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@damacus damacus merged commit 1c67e42 into main May 12, 2026
4 checks passed
@damacus damacus deleted the fix/data-usage-error-handling-9830336635236494968 branch May 12, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant