Skip to content

🧹 [code health] Capture and log DataUsageInfo error in BucketsHandler#63

Merged
damacus merged 1 commit into
mainfrom
fix/buckets-handler-data-usage-error-8208180753805297782
May 12, 2026
Merged

🧹 [code health] Capture and log DataUsageInfo error in BucketsHandler#63
damacus merged 1 commit into
mainfrom
fix/buckets-handler-data-usage-error-8208180753805297782

Conversation

@damacus
Copy link
Copy Markdown
Owner

@damacus damacus commented May 11, 2026

🎯 What: The code health issue addressed
The ListBuckets handler in internal/handlers/buckets_handler.go previously ignored the error returned from mdm.DataUsageInfo. This PR modifies the handler to capture this error and log it using c.Logger().Warnf() if it's not nil. It additionally runs formatting (go fmt) on the codebase.

💡 Why: How this improves maintainability
Ignoring errors can hide bugs or configuration issues (like lack of admin permissions to view data usage stats or unexpected connectivity failures with MinIO). Logging it at the Warning level ensures that we are aware of any failure retrieving this auxiliary data without blocking the main intent of listing user buckets.

Verification: How you confirmed the change is safe

  • Executed unit tests (go test ./...) successfully.
  • Code changes were reviewed by static analyzer tools and go fmt.
  • Reviewed the Echo Context's logging system to confirm proper warning propagation.
  • Using standard DataUsageInfo with explicit nil checks doesn't change standard handler flow behavior on success or error.

Result: The improvement achieved
A clear improvement to our logs indicating issues related to storage usage queries while preventing silent failures, enriching debugging and operability of IronBuckets.


PR created automatically by Jules for task 8208180753805297782 started by @damacus

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@damacus damacus merged commit 7626705 into main May 12, 2026
4 checks passed
@damacus damacus deleted the fix/buckets-handler-data-usage-error-8208180753805297782 branch May 12, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant