Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install on MacOs and fixed --help-coins option #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zwilla
Copy link
Contributor

@Zwilla Zwilla commented Nov 5, 2019

Section how to install on macOS
and fixed --help-coins option
also fixed the header tags h1 to h6, note there can only exist one h1 and it is the repro name all others are smaller
will change later the wrong --helpcoins to --help-coins also at src/Utils/Util.php

Section how to install on macOS
and fixed --help-coins option
also fixed the header tags h1 to h6, note there can only exist one h1 and it is the repro name all others are smaller 
will change later the wrong --helpcoins  to --help-coins also at src/Utils/Util.php
@dan-da
Copy link
Owner

dan-da commented Nov 5, 2019

thx for the PR!

I like the MacOS instructions, the --help-coins fix, and the fix to one of the examples removing /home/websites.

I'm less excited about changing all the indents in the readme. Plus it makes for a messy diff.

If you update this PR to include only the above changes without altering indents I will merge it right away.

For indent changes, you could make a separate PR for that. I would need to merge it locally to look at it before approving.

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants