Add functionality from new app version #83

dan-r · 2024-07-07T10:25:01Z

PR to add functionality related to the new version of the app.

So far this includes:

Charge slot list is provided by Ohme directly so is now fully accurate
Current and next slot sensors also benefit from the above
Switching from max charge to smart charge (and vice versa) now works more reliably due to API changes

Can I please get some people to test the latest beta release (howto) out? Mainly:

@HnabrU from Slot Active sensor incorrect state #80
@jeldwendean for the batpred stuff, as the way slots are fetched has changed
@andyvee69 as a sanity check - also incase I've missed anything you think is useful from the new app. I know you've had a bit longer to play around with it than I have!
Any one else who sees this!

deanjesper · 2024-07-07T11:15:27Z

I'll upgrade and have a play tonight 😀 @dan-r

deanjesper · 2024-07-07T17:54:21Z

I'm getting this message for Charge Slot Active:

deanjesper · 2024-07-07T17:56:57Z

Interestingly the slots are blank too:

deanjesper · 2024-07-07T18:01:29Z

And Car Charging is 'Not charging' when it is

Sorry for the comment spam 😂

dan-r · 2024-07-07T18:09:45Z

Any errors in the logs?

deanjesper · 2024-07-07T18:12:49Z

Any errors in the logs?

Yeah quite a few

`Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:727
integration: Sensor (documentation, issues)
First occurred: 18:50:21 (3 occurrences)
Last logged: 18:57:33

ohme: Error on device update!
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 727, in _async_add_entity
await entity.async_device_update(warning=False)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1296, in async_device_update
await self.async_update()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 529, in async_update
await self.coordinator.async_request_refresh()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 262, in async_request_refresh
await self._debounced_refresh.async_call()
File "/usr/src/homeassistant/homeassistant/helpers/debounce.py", line 114, in async_call
await task
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 288, in async_refresh
await self._async_refresh(log_failures=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 411, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 165, in async_update_listeners
update_callback()
File "/config/custom_components/ohme/sensor.py", line 414, in _handle_coordinator_update
self._state = next_slot(self.coordinator.data)['end']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/utils.py", line 11, in next_slot
slots = slot_list(data)
^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/utils.py", line 37, in slot_list
wh_tally = data['batterySocBefore']['wh'] # Get the wh value we start from
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
TypeError: 'NoneType' object is not subscriptable`

`This error originated from a custom integration.

Logger: homeassistant
Source: custom_components/ohme/sensor.py:471
integration: Ohme (documentation, issues)
First occurred: 18:46:31 (2 occurrences)
Last logged: 18:47:01

Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 255, in _handle_refresh_interval
await self._async_refresh(log_failures=True, scheduled=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 411, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 165, in async_update_listeners
update_callback()
File "/config/custom_components/ohme/sensor.py", line 471, in _handle_coordinator_update
self._state = reduce(lambda acc, slot: acc + f"{slot['start'].strftime('%H:%M')}-{slot['end'].strftime('%H:%M')}, ", slots, "")[:-2]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: reduce() arg 2 must support iteration`

`Logger: homeassistant.components.binary_sensor
Source: helpers/entity_platform.py:912
integration: Binary Sensor (documentation, issues)
First occurred: 18:50:21 (3 occurrences)
Last logged: 18:57:33

Error adding entity binary_sensor.ohme_slot_active for domain binary_sensor with platform ohme
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 912, in _async_add_entity
await entity.add_to_platform_finish()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1362, in add_to_platform_finish
self.async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1007, in async_write_ha_state
self._async_write_ha_state()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1133, in _async_write_ha_state
state, attr, capabilities, shadowed_attr = self.__async_calculate_state()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1072, in __async_calculate_state
if extra_state_attributes := self.extra_state_attributes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/binary_sensor.py", line 299, in extra_state_attributes
"planned_dispatches": [x for x in slots if not x['end'] or x['end'] > now],
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not iterable`

dan-r · 2024-07-07T20:04:24Z

@deanjesper any better with the latest beta?

deanjesper · 2024-07-07T20:22:39Z

@deanjesper any better with the latest beta?

I've got a Predbat error now, looks like the completedDispatches timestamp for 18:48 has a decimal point on the seconds

Error: Exception raised time data '2024-07-07T18:48:15.663000+01:00' does not match format '%Y-%m-%dT%H:%M:%S%z'

Planned dispatches

start: '2024-07-07T21:15:00+01:00'
end: '2024-07-07T21:30:00+01:00'
charge_in_kwh: -0.744
source: smart-charge
location: null
start: '2024-07-07T21:30:00+01:00'
end: '2024-07-07T22:00:00+01:00'
charge_in_kwh: -1.001
source: smart-charge
location: null
start: '2024-07-07T23:00:00+01:00'
end: '2024-07-08T05:32:08+01:00'
charge_in_kwh: -43.068
source: smart-charge
location: null
Completed dispatches
start: '2024-07-07T18:48:15.663000+01:00'
end: '2024-07-07T19:00:00+01:00'
charge_in_kwh: -0.803
source: smart-charge
location: null
start: '2024-07-07T19:15:00+01:00'
end: '2024-07-07T20:00:00+01:00'
charge_in_kwh: -2.543
source: smart-charge
location: null

dan-r · 2024-07-07T20:34:01Z

What about now?

deanjesper · 2024-07-07T20:40:06Z

What about now?

All good now! Nice work. I'll see how it is in the morning when I wake up and feed back!

deanjesper · 2024-07-08T05:35:52Z

Just woke up and my car is still charging and I've been given more slots but the integration can't see them, odd. Another error too:

This error originated from a custom integration.

Logger: homeassistant
Source: custom_components/ohme/utils.py:46
integration: Ohme (documentation, issues)
First occurred: 03:02:14 (422 occurrences)
Last logged: 06:32:45

Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 255, in _handle_refresh_interval
await self._async_refresh(log_failures=True, scheduled=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 411, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 165, in async_update_listeners
update_callback()
File "/config/custom_components/ohme/sensor.py", line 414, in _handle_coordinator_update
self._state = next_slot(self.coordinator.data)['end']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/utils.py", line 11, in next_slot
slots = slot_list(data)
^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/utils.py", line 46, in slot_list
"charge_in_kwh": -((slot['estimatedSoc']['wh'] - wh_tally) / 1000), # Work out how much we add in just this slot
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
TypeError: unsupported operand type(s) for -: 'int' and 'NoneType'

The car should be charged in the next few minutes so not sure why it's decided to give more slots but what's odd is the integration thinks there are no more.

deanjesper · 2024-07-08T05:38:41Z

Another error when I paused the charge in the Ohme app and reloaded the integration in HA

Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:727
integration: Sensor (documentation, issues)
First occurred: 06:37:26 (1 occurrences)
Last logged: 06:37:26

ohme: Error on device update!
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 727, in _async_add_entity
await entity.async_device_update(warning=False)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1296, in async_device_update
await self.async_update()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 529, in async_update
await self.coordinator.async_request_refresh()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 262, in async_request_refresh
await self._debounced_refresh.async_call()
File "/usr/src/homeassistant/homeassistant/helpers/debounce.py", line 114, in async_call
await task
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 288, in async_refresh
await self._async_refresh(log_failures=True)
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 411, in _async_refresh
self.async_update_listeners()
File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 165, in async_update_listeners
update_callback()
File "/config/custom_components/ohme/sensor.py", line 414, in _handle_coordinator_update
self._state = next_slot(self.coordinator.data)['end']
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/utils.py", line 11, in next_slot
slots = slot_list(data)
^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/utils.py", line 46, in slot_list
"charge_in_kwh": -((slot['estimatedSoc']['wh'] - wh_tally) / 1000), # Work out how much we add in just this slot
~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
TypeError: unsupported operand type(s) for -: 'int' and 'NoneType'

dan-r · 2024-07-08T19:38:15Z

Right that should be fixed now

deanjesper · 2024-07-09T05:41:45Z

Right that should be fixed now

I'll give it a go tonight 😊

deanjesper · 2024-07-10T06:41:37Z

Right that should be fixed now

I'll give it a go tonight 😊

All good, no errors!

dan-r · 2024-07-10T16:55:24Z

Thanks for your testing! I'll publish that now look out for feedback once more people start to use it.

dan-r added 5 commits July 3, 2024 22:36

Fix for #82

7712431

Initial work for new API

9781621

Fix attributes expected for batpred

5460095

Use new method to disable max charge

56c2efb

Bump version

21db0e5

Fix some teething problems and missing checks

48082d5

Remove ms from predbat slots

5ec6a42

Add additional None check

0af1968

dan-r merged commit 7bd0d37 into main Jul 10, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add functionality from new app version #83

Add functionality from new app version #83

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 7, 2024

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 8, 2024

deanjesper commented Jul 8, 2024

dan-r commented Jul 8, 2024

deanjesper commented Jul 9, 2024

deanjesper commented Jul 10, 2024

dan-r commented Jul 10, 2024

Add functionality from new app version #83

Add functionality from new app version #83

Conversation

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 7, 2024

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

dan-r commented Jul 7, 2024

deanjesper commented Jul 7, 2024

deanjesper commented Jul 8, 2024

deanjesper commented Jul 8, 2024

dan-r commented Jul 8, 2024

deanjesper commented Jul 9, 2024

deanjesper commented Jul 10, 2024

dan-r commented Jul 10, 2024