Add MSVC trybot and CI back

Fixes chromium#267
danakj · Dec 3, 2023 · dff3e1f · dff3e1f
1 parent 6cae793
commit dff3e1f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 22 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,17 +12,15 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        # MSVC is broken: https://github.com/chromium/subspace/issues/267
-        #- {
-        #    name: "Windows MSVC",
-        #    artifact: "Windows-MSVC.tar.xz",
-        #    os: windows-latest,
-        #    build_type: "Release",
-        #    cc: "cl",
-        #    cxx: "cl",
-        #    environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
-        #  }
-
+        - {
+          name: "Windows MSVC",
+          artifact: "Windows-MSVC.tar.xz",
+          os: windows-latest,
+          build_type: "Release",
+          cc: "cl",
+          cxx: "cl",
+          environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
+        }
         #- {
         #    name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
         #    os: windows-latest,

diff --git a/.github/workflows/try.yml b/.github/workflows/try.yml
@@ -15,17 +15,15 @@ jobs:
       fail-fast: false
       matrix:
         config:
-        # MSVC is broken: https://github.com/chromium/subspace/issues/267
-        #- {
-        #    name: "Windows MSVC",
-        #    artifact: "Windows-MSVC.tar.xz",
-        #    os: windows-latest,
-        #    build_type: "Release",
-        #    cc: "cl",
-        #    cxx: "cl",
-        #    environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
-        #  }
-
+        - {
+          name: "Windows MSVC",
+          artifact: "Windows-MSVC.tar.xz",
+          os: windows-latest,
+          build_type: "Release",
+          cc: "cl",
+          cxx: "cl",
+          environment_script: "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Auxiliary/Build/vcvars64.bat",
+        }
         #- {
         #    name: "Windows MinGW", artifact: "Windows-MinGW.tar.xz",
         #    os: windows-latest,