Merge pull request #54 from dancier/feature/fix-pw-reset-link

fix password reset link in email
dancier · Jun 17, 2023 · ac10493 · ac10493
2 parents d4c3d76 + ba0e09a
commit ac10493
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Readme.md b/Readme.md
@@ -65,8 +65,6 @@ docker-compose stop dancer;
 Show test coverage in target/site/jacoco/index.html: 
 `.target/site/jacoco/index.html
 
-
-
 ### Accessing the API-Definition
 [OpenApi](https://editor.swagger.io/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fdancier%2Fdancer%2Fmaster%2Fopenapi.yml)
 

diff --git a/src/main/java/net/dancier/dancer/authentication/service/AuthenticationService.java b/src/main/java/net/dancier/dancer/authentication/service/AuthenticationService.java
@@ -132,7 +132,7 @@ private void handleRegistrationAttemptOfAlreadyExistingAccount(User user) {
     }
 
     private String passwordResetLink(String passwordResetCode) {
-        return frontendBaseName + "/authentication/change-password/" + passwordResetCode;
+        return frontendBaseName + "/registration/reset-password/" + passwordResetCode;
     }
 
     private String emailValidationLink(String validationCode) {
@@ -170,7 +170,7 @@ public User checkEmailValidationCode(String code) {
                 .findByCode(code).orElseThrow(() ->new ApplicationException("Unable to validate"));
         if (emailValidationCode.getExpiresAt().isBefore(Instant.now())) {
             throw new ApplicationException("Unable to Validate, code already expired");
-        };
+        }
         User user = userRepository.findById(emailValidationCode
                 .getUserId())
                 .orElseThrow(() -> new ApplicationException("No user associated with this code."));