Skip to content

Fix cumulative bar gaps and text #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025
Merged

Fix cumulative bar gaps and text #24

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a08e4f3
fix: fix gaps during cumulative mode and always use bargap
Jul 10, 2025
33530ca
fix: fix gaps during cumulative mode and always use bargap
Jul 10, 2025
1a8188a
fix: title ternary
Jul 10, 2025
3e133bc
fix: standardize capitalization
Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,6 @@ function load_over_time_plot(dandiset_id) {

const plot_info = [
{
//type: "scatter",
//mode: "lines+markers",
type: "bar",
x: dates, // Use raw dates for proper alignment
y: plot_data,
Expand All @@ -280,8 +278,9 @@ function load_over_time_plot(dandiset_id) {
];

const layout = {
bargap: 0,
title: {
text: `Bytes sent per day`,
text: USE_CUMULATIVE ? `Total bytes sent to date` : `Bytes sent per day` ,
font: { size: 24 }
},
xaxis: {
Expand All @@ -304,6 +303,23 @@ function load_over_time_plot(dandiset_id) {
},
};

if (USE_CUMULATIVE) {
const date_set = new Set(dates);
const min_date = new Date(Math.min(...dates.map(d => new Date(d))));
const max_date = new Date(Math.max(...dates.map(d => new Date(d))));
let all_dates = [];
for (let date = new Date(min_date); date <= max_date; date.setDate(date.getDate() + 1)) {
all_dates.push(date.toISOString().slice(0, 10));
}
const missing_dates = all_dates.filter(date => !date_set.has(date));

layout.xaxis.rangebreaks = [
{
values: missing_dates
}
];
}

Plotly.newPlot(plot_element_id, plot_info, layout);
})
.catch((error) => {
Expand Down Expand Up @@ -379,6 +395,7 @@ function load_per_asset_histogram(dandiset_id) {
];

const layout = {
bargap: 0,
title: {
text: `Bytes sent per asset`,
font: { size: 24 }
Expand Down Expand Up @@ -493,7 +510,7 @@ function load_geographic_heatmap(dandiset_id) {

const layout = {
title: {
text: "Bytes Sent by Region",
text: "Bytes sent by region",
font: { size: 24 },
},
geo: {
Expand Down