Add incomplete upload dialog to DLP when unembargo is blocked #2082
+291
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
requested changes
Nov 26, 2024
dandiapi/api/views/dandiset.py
Outdated
Comment on lines
467
to
482
| @swagger_auto_schema( | ||
| methods=['GET'], | ||
| manual_parameters=[DANDISET_PK_PARAM], | ||
| request_body=no_body, | ||
| operation_summary='List active/incomplete uploads in this dandiset.', | ||
| ) | ||
| @action(methods=['GET'], detail=True) | ||
| def uploads(self, request, dandiset__pk): | ||
| dandiset: Dandiset = self.get_object() | ||
|
|
||
| # Special case where a "safe" method is access restricted, due to the nature of uploads | ||
| self.require_owner_perm(dandiset) | ||
|
|
||
| uploads: QuerySet[Upload] = dandiset.uploads.all() | ||
| serializer = DandisetUploadSerializer(instance=uploads, many=True) | ||
| return Response(serializer.data, status=status.HTTP_200_OK) |
There was a problem hiding this comment.
I think we should paginate these. Someone could theoretically DoS the server by creating thousands of uploads (which may be a completely legitimate action) and then hitting this endpoint.
There was a problem hiding this comment.
Just pushed that change. It's a bit awkward since we can't use the default pagination behavior, due to this being a "detailed" endpoint that still needs pagination. That was originally the reason I didn't bother, since it seemed unlikely to be an issue anyway, but better safe than sorry. I've also changed the client to match that, and tested it locally, confirming the overall behavior is unchanged.
jjnesbitt
force-pushed
the
upload-lifecycle-management
branch
from
6ccaeb6
to
f1078bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we've had several instances of a dandiset unembargo being blocked by incomplete/active uploads. Most of the time, these uploads are junk and the owners simply wish to clear them, which requires admin intervention. This PR adds the API and Vue client support for users to list and delete these lingering uploads themselves.
Here is a video of the new UI.
dandi-unembargo-uploads-2024-11-21_14.18.53.mp4