Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ls WiP: tried to add filtering and {}formating with alt names #1118

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

Example is quite neatly working for remote dandiset

(git)lena:~/proj/dandi/dandi-cli-master[master]git
$> dandi --pdb ls -F 'path,size,ID=={metadata[id]}' -f pyout -r --metadata assets dandi://dandi/000029@draft/
PATH                                             SIZE    ID
000029                                           20.7 MB DANDI:000029/draft
sub-anm369964/sub-anm369964_behavior+ecephys.nwb 7.7 MB  dandiasset:689d7c0c-d980-462e-9a56-3df87efc9658
sub-RAT123/sub-RAT123.nwb                        18.8 kB dandiasset:86e09d7e-4355-4887-9c5a-7a137c046953
sub-anm369962/sub-anm369962_behavior+ecephys.nwb 6.6 MB  dandiasset:4f6a8f1d-ca04-491f-a530-9ed00a909c21
sub-anm369963/sub-anm369963_behavior+ecephys.nwb 6.4 MB  dandiasset:38f2024d-62a9-4c79-8a22-7a0ff34b331d
Summary:                                         41.4 MB

but for the local one with all the async fields we do not get it and crashes etc. I guess in the light of not yet addressed #939 this PR should be just considered as a proof of concept instead of anything directly mergeable, and then incorporated into reworking of #939 "specification"

Example is quite neatly working for remote dandiset

	(git)lena:~/proj/dandi/dandi-cli-master[master]git
	$> dandi --pdb ls -F 'path,size,ID=={metadata[id]}' -f pyout -r --metadata assets dandi://dandi/000029@draft/
	PATH                                             SIZE    ID
	000029                                           20.7 MB DANDI:000029/draft
	sub-anm369964/sub-anm369964_behavior+ecephys.nwb 7.7 MB  dandiasset:689d7c0c-d980-462e-9a56-3df87efc9658
	sub-RAT123/sub-RAT123.nwb                        18.8 kB dandiasset:86e09d7e-4355-4887-9c5a-7a137c046953
	sub-anm369962/sub-anm369962_behavior+ecephys.nwb 6.6 MB  dandiasset:4f6a8f1d-ca04-491f-a530-9ed00a909c21
	sub-anm369963/sub-anm369963_behavior+ecephys.nwb 6.4 MB  dandiasset:38f2024d-62a9-4c79-8a22-7a0ff34b331d
	Summary:                                         41.4 MB

but for the local one with all the async fields we do not get it and crashes
etc.
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 88.55% // Head: 66.63% // Decreases project coverage by -21.92% ⚠️

Coverage data is based on head (8bccbf5) compared to base (d5ed594).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1118       +/-   ##
===========================================
- Coverage   88.55%   66.63%   -21.93%     
===========================================
  Files          76       73        -3     
  Lines        9117     8416      -701     
===========================================
- Hits         8074     5608     -2466     
- Misses       1043     2808     +1765     
Flag Coverage Δ
unittests 66.63% <0.00%> (-21.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_ls.py 13.02% <0.00%> (-62.55%) ⬇️
dandi/support/tests/test_iterators.py 13.15% <0.00%> (-86.85%) ⬇️
dandi/support/tests/test_digests.py 16.66% <0.00%> (-83.34%) ⬇️
dandi/bids_utils.py 0.00% <0.00%> (-80.77%) ⬇️
dandi/tests/test_pynwb_utils.py 20.00% <0.00%> (-77.78%) ⬇️
dandi/cli/tests/test_formatter.py 22.22% <0.00%> (-77.78%) ⬇️
dandi/cli/tests/test_ls.py 22.38% <0.00%> (-77.62%) ⬇️
dandi/tests/test_organize.py 18.40% <0.00%> (-76.75%) ⬇️
dandi/tests/test_validate.py 26.66% <0.00%> (-73.34%) ⬇️
dandi/cli/tests/test_command.py 31.25% <0.00%> (-68.75%) ⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant