Bump test timeout to 330s #1505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
Python 3.12 tests were becoming flakey. Specifically: dandi/tests/test_metadata.py::test_nwb2asset_remote_asset - Failed: Timeout >300.0s
asmacdo
force-pushed
the
increase-timeout
branch
from
63e7b92
to
7065a3b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1505 +/- ##
==========================================
+ Coverage 88.56% 88.63% +0.07%
==========================================
Files 77 77
Lines 10572 10572
==========================================
+ Hits 9363 9371 +8
+ Misses 1209 1201 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I am afraid it is more systematic etc |
|
Thanks @yarikoptic sorry i missed that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.12 tests were becoming flakey
Specifically: dandi/tests/test_metadata.py::test_nwb2asset_remote_asset - Failed: Timeout >300.0s