Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add one photon to metadata dict #1532

Merged
merged 1 commit into from
Nov 21, 2024
Merged

add one photon to metadata dict #1532

merged 1 commit into from
Nov 21, 2024

Conversation

bendichter
Copy link
Member

@bendichter bendichter commented Nov 20, 2024

OnePhotonSeries is a newer data type, which is why it was not included in the original list

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (958adbe) to head (e041653).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
+ Coverage   88.45%   88.53%   +0.07%     
==========================================
  Files          78       78              
  Lines       10691    10691              
==========================================
+ Hits         9457     9465       +8     
+ Misses       1234     1226       -8     
Flag Coverage Δ
unittests 88.53% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Nov 21, 2024
@yarikoptic
Copy link
Member

thank you!

@yarikoptic yarikoptic merged commit fd3f5e6 into master Nov 21, 2024
23 of 25 checks passed
@yarikoptic yarikoptic deleted the add-one-photon branch November 21, 2024 00:57
Copy link

🚀 PR was released in 0.65.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants