Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some type-checking errors under Python 3.13 #1539

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 25, 2024

No description provided.

@jwodder jwodder added the tests Add or improve existing tests label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (ff49fd1) to head (6e8286e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
+ Coverage   88.44%   88.53%   +0.08%     
==========================================
  Files          78       78              
  Lines       10691    10691              
==========================================
+ Hits         9456     9465       +9     
+ Misses       1235     1226       -9     
Flag Coverage Δ
unittests 88.53% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

could you please add a comment on why it is needed -- what are we overriding?

@jwodder
Copy link
Member Author

jwodder commented Nov 25, 2024

@yarikoptic Comment added.

@yarikoptic yarikoptic merged commit a832b95 into master Nov 26, 2024
24 of 25 checks passed
@yarikoptic yarikoptic deleted the ign-type-py13 branch November 26, 2024 04:10
Copy link

🚀 PR was released in 0.65.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants