Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MATLAB docker file with last 2024b version #224

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aranega
Copy link
Contributor

@aranega aranega commented Jan 17, 2025

This PR updates the base version of MATLAB to 2024b, and updates the version of matnwb from 2.6.0.2 to 2.7.0

Copy link
Member

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aranega. Please also update the docker-test.yaml matrix and docker-push.yaml matrix so that we can automate the build/publishing through GitHub Actions.

@aranega
Copy link
Contributor Author

aranega commented Jan 17, 2025

@kabilar Thanks for the quick review! I'll update that asap. The PR is still in draft mode at the moment though as it depends on a PR on this repository. Well, the image can build without, but the live-script example will not be usable without some extra modifications.

@vijayiyer05
Copy link

FYI @aranega: I had a check-in with Ryan this week and he's now merged the dependent PR on the examples repository.

@aranega
Copy link
Contributor Author

aranega commented Jan 31, 2025

@vijayiyer05 thats perfect, thanks a lot 🙏!
I'll modify asap the build matrix and mark this PR as ready to review as soon as it's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants