Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable trailing delete in production #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented Sep 9, 2024

Requirements before merging this PR

@@ -17,7 +16,6 @@ module "sponsored_embargo_bucket" {
source = "./modules/dandiset_bucket"
bucket_name = "dandiarchive-embargo"
versioning = false
trailing_delete = false
heroku_user = data.aws_iam_user.api
log_bucket_name = "dandiarchive-embargo-logs"
providers = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this month-old PR is still a draft, I would like right away to adjust policies here to exclude /zarr/ prefix from trailing delete functionality -- we do want to keep prior versionIds even after DeleteMarker is added.

What would that entail?

Ref:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened a PR to address this (#190). Once that's merged, this PR will be unblocked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@yarikoptic
Copy link
Member

@mvandenburgh could you please add into original description a list of TODOs for this PR to be accomplished for it to come out of Draft and be merged/deployed.

@mvandenburgh mvandenburgh changed the base branch from master to scoped-lifecycle-policy October 22, 2024 17:52
Base automatically changed from scoped-lifecycle-policy to master October 28, 2024 19:26
An error occurred while trying to automatically change base from scoped-lifecycle-policy to master October 28, 2024 19:26
@mvandenburgh mvandenburgh marked this pull request as ready for review October 29, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants