-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable trailing delete in production #186
base: master
Are you sure you want to change the base?
Conversation
9cd08b4
to
733a3fc
Compare
@@ -17,7 +16,6 @@ module "sponsored_embargo_bucket" { | |||
source = "./modules/dandiset_bucket" | |||
bucket_name = "dandiarchive-embargo" | |||
versioning = false | |||
trailing_delete = false | |||
heroku_user = data.aws_iam_user.api | |||
log_bucket_name = "dandiarchive-embargo-logs" | |||
providers = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this month-old PR is still a draft, I would like right away to adjust policies here to exclude /zarr/
prefix from trailing delete functionality -- we do want to keep prior versionIds even after DeleteMarker is added.
What would that entail?
Ref:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a PR to address this (#190). Once that's merged, this PR will be unblocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
@mvandenburgh could you please add into original description a list of TODOs for this PR to be accomplished for it to come out of Draft and be merged/deployed. |
733a3fc
to
f689629
Compare
f689629
to
32cade8
Compare
Requirements before merging this PR
blobs
prefix only #190 and rebase this PR on master