Manifest file garbage collection #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
expire-noncurrent-manifest-files
branch
2 times, most recently
from
156daf8 to
4cf1d2d
Compare
jjnesbitt
reviewed
Dec 2, 2024
See #192 for rationale behind one day rule.
mvandenburgh
force-pushed
the
expire-noncurrent-manifest-files
branch
from
4cf1d2d to
744e744
Compare
jjnesbitt
approved these changes
Dec 2, 2024
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192.
Configures an S3 lifecycle rule to cap the number of noncurrent versions of manifest files to 1. See #192 for the rationale behind this rule.
Note - this only enables it in staging. After merging and verifying that it works correctly, I'll make a follow up PR enabling it for the production bucket.