-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add releaseNotes property to published dandiset #185
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 18 18
Lines 1799 1801 +2
=======================================
+ Hits 1757 1759 +2
Misses 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
better add some record to some unittest to exercise this optional field, so there would be a "detector" for removing/breaking it. |
hm, I am confused why schemata version is not changed... we are adding a field so should get at least a patch version boost I guess in comparison to the latest release -- may be back then we had already some changes staged. Should rebase/push again and see what happens. will do now |
5d261f7
to
4a20cf2
Compare
this will indeed have a schema change, but we only added the update to schema version in a relevant corresponding PR. |
this will allow change of the UI to add a field alongside publishing for releaseNotes.
we should also consider adding optional
CHANGES
andREADME
files to the Dandiset model.