Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare typing_extensions dependency #248

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Declare typing_extensions dependency #248

merged 1 commit into from
Aug 13, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Aug 13, 2024

Use of typing_extensions was reintroduced to the code in commit 0d38117 (#203), but typing_extensions was not added to the runtime requirements. This PR fixes that.

@jwodder jwodder added the dependencies Update one or more dependencies version label Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (2643846) to head (b20ebee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          16       16           
  Lines        1727     1727           
=======================================
  Hits         1688     1688           
  Misses         39       39           
Flag Coverage Δ
unittests 97.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit 8648e4a into master Aug 13, 2024
77 checks passed
@yarikoptic yarikoptic deleted the typing-ext branch August 13, 2024 13:48
@yarikoptic
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants