Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle failed requests to retrieve the schema #251

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

danlamanna
Copy link
Contributor

We ran into this a week or so ago when github had their outage. This should provide a clearer exception than the JSONDecodeError we saw.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (6fc16b8) to head (dd8a837).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          16       16           
  Lines        1739     1741    +2     
=======================================
+ Hits         1700     1702    +2     
  Misses         39       39           
Flag Coverage Δ
unittests 97.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@candleindark
Copy link
Member

LGTM. Thank @danlamanna. @yarikoptic, merge? The test-dandi-cli (ubuntu-latest, 3.8, dandi-devel, master) is hung. I couldn't restart it.

@yarikoptic
Copy link
Member

FWIW, that test stall is not new:

I restarted that run just in case.

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Sep 5, 2024
@yarikoptic yarikoptic merged commit d2f07e2 into master Sep 5, 2024
80 checks passed
@yarikoptic yarikoptic deleted the properly-handle-fetch-errors branch September 5, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants