Refactoring model so we could avoid shortcoming of linkml model #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since Any also represents List or anything else really.
I thought that it might be used somewhere in the meditor to edit dandiset metadata
but it seems that nothing of that type propagated into dandiset metadata so
it should not be effected
=== Do not change lines below ===
{
"chain": [],
"cmd": "git-sedi 'Union\\[Any, List\\[Any\\]\\]' Any",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
…s) for Locus and Allele So far I see no values with such data types used at all in dandi archive so we should not break anything An alternative would be to just make it a List[Identifier] always and not bother allowing for the dance of singular-vs-plural.
That would avoid Union of a list with non-multivalued identifier. And we already have data with string value describing the genotype -- it is not really an identifier!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcoming in question:
AFAIK this should result in no changes necessary to metadata records since none of those "features" was used. So even though we break the model, I think we could just go with "patch" level progress forward.
Individual commits have more information.
TODOs also