-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "version" to datacite record and bundle datacite json serializations #260
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 97.58% 97.59%
=======================================
Files 16 16
Lines 1739 1745 +6
=======================================
+ Hits 1697 1703 +6
Misses 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
all tests are failing with similar
I think it might be worth just shipping copies of desired verion(s) of datacite serializations right in here, in particular since we are referencing a specific to commit version. |
dandi-cli versions failing to install with
since here we have not yet dropped 3.8 and in dandi-cli already did... |
i'm wondering if we really want to keep all the version from these repositories, or decide on one that we want to match. Or perhaps we want to create our own? |
we had to do
Moreover, with exposing version in the code we could try one or another easily and consistently across versions. |
folded in a typo fix
….py + fix typing issue
38da3b3
to
a9c909f
Compare
folded in a typo fix
partially addresses
This PR also bundles (all known versions) datacite json schemas.