-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document on how the Archive API is used #224
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
===========================================
+ Coverage 52.12% 79.51% +27.39%
===========================================
Files 29 34 +5
Lines 4033 6574 +2541
===========================================
+ Hits 2102 5227 +3125
+ Misses 1931 1347 -584 ☔ View full report in Codecov by Sentry. |
@yarikoptic Is there anything in this document that you think could be improved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asked for some clarifications and references
@@ -0,0 +1,156 @@ | |||
How `dandidav` Uses the DANDI Archive API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there "caching" of requests somehow based e.g. on modified timestamp per dandiset or anything related? that would then be useful to mention since would relate to "How".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The only caching is for Zarr manifests.
|
||
- When responding to a `PROPFIND` request with a `Depth` header of `0` | ||
(hereafter referred to as a "shallow request"), `dandidav` requests only the | ||
resource identified by the request path, not any of its children. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens for Depth
request with infinity
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reject those immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like worth documenting here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 0ec52e5.
@yarikoptic Please re-review. |
@yarikoptic Ping. |
No description provided.