Stop providing getcontenttype WebDAV property for Zarr entries
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, PROPFIND responses from `dandidav` declare all Zarr entries to have Content-Types of "application/octet-stream". However, now that dandi-cli is going to be setting the Content-Type for certain Zarr entries to "application/json", this will start being incorrect. S3's `list_objects_v2` endpoint doesn't return object Content-Types, so we can't efficiently find out what files dandi-cli has declared as JSON, so the next best option is just stop providing the Content-Type for all Zarr entries. Note that this only affects metadata returned using the WebDAV protocol, which I don't think anyone is using anyway.
jwodder
added
correctness
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 79.53% 79.52% -0.02%
==========================================
Files 34 34
Lines 6588 6589 +1
==========================================
Hits 5240 5240
- Misses 1348 1349 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PROPFIND responses from
dandidavdeclare all Zarr entries to have Content-Types of "application/octet-stream". However, now that dandi-cli is going to be setting the Content-Type for certain Zarr entries to "application/json", this will start being incorrect. S3'slist_objects_v2endpoint doesn't return object Content-Types, so we can't efficiently find out what files dandi-cli has declared as JSON, so the next best option is just stop providing the Content-Type for all Zarr entries.Note that this only affects metadata returned using the WebDAV protocol, which I don't think anyone is using anyway.