Add support of generating diff reports for jsonschema validation errors #59

candleindark · 2025-01-27T18:33:28Z

Add support of generating diff reports for jsonschema validation errors to the diff-manifests-reports subcommand.

Additionally, this PR removes table for error diff at each dandiset.

To include jsonschema validation errors and their diff

By including jsonschema validation errors and diffs

To allow precise annotation in arguments

To reduce code duplications

For counting

To include jsonschema validation errs

…tegorizer`

…rts`

In `_output_validation_diff_reports()`

To reduce code duplication

To improve performance

To use for both Pydantic and JSON Schema validation errs

candleindark added 30 commits January 24, 2025 16:21

feat: expand _DandiValidationDiffReport

b265afc

To include jsonschema validation errors and their diff

feat: populate the expanded _DandiValidationDiffReport

633fc29

By including jsonschema validation errors and diffs

feat: provide helper func to count Pydantic validation errs

e792dd0

fix: correct type annotation for pydantic_err_categorizer()

e8a5ba7

rf: define a type alia for pydantic validation err reps

2878335

rf: rename param of count_pydantic_validation_errs()

0467b9a

fix: relax type annotation of ValidationErrCounter

8b48595

To allow precise annotation in arguments

feat: define helper func to extract validation error reps from reports

4ea8ffe

rf: use err_reps and count_pydantic_validation_errs()

99e0b77

To reduce code duplications

feat: add helper func that defines jsonschema validation err rep

6865efb

For counting

doc: improve docstring

b7c2fab

feat: augment err_reps

8e0eee4

To include jsonschema validation errs

rf: refactor logic for counting validation errs into func

040fffd

feat: define func to categorize jsonschema validation errs

3c41a79

fix: correct type annotation and rename local var in `pydantic_err_ca…

4e5e538

…tegorizer`

fix: remove type assumption in PydanticValidationErrRep

7501377

feat: define helper for counting jsonschema validation errs

13d185c

feat: count json schema validation errs

75b58fe

rf: reduce code duplication in `_output_dandiset_validation_diff_repo…

574a285

…rts`

feat: remove table error diff at each dandiset

5ad0271

In `_output_validation_diff_reports()`

rf: refactor code for outputting supporting files

c4b1d4d

To reduce code duplication

rf: redefine constant vars in _output_supporting_files() as constants

fe60585

To improve performance

feat: include jsonschema validation related data in supporting files

0a4af51

rf: move output of supporting files out of summary file context

7e57bcd

rf: set summary file name for Pydantic errs as a global var

6c7a9e9

doc: improve docstring for validation_err_diff

c7e7c19

fix: remove extra bundling in jsonschema_err_categorizer()

e4fc3e5

fix: make categories in jsonschema_err_categorizer broader

f39e147

rf: make a general validation err diff summary func

9119692

To use for both Pydantic and JSON Schema validation errs

feat: output summary tables for JSON validation err diff

17c7ce4

candleindark marked this pull request as ready for review January 28, 2025 18:46

candleindark merged commit 5ffc825 into dandi:main Jan 28, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support of generating diff reports for jsonschema validation errors #59

Add support of generating diff reports for jsonschema validation errors #59

candleindark commented Jan 27, 2025 •

edited

Loading

Add support of generating diff reports for jsonschema validation errors #59

Add support of generating diff reports for jsonschema validation errors #59

Conversation

candleindark commented Jan 27, 2025 • edited Loading

candleindark commented Jan 27, 2025 •

edited

Loading