Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make boto3 and zarr extra dependencies #39

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Make boto3 and zarr extra dependencies #39

merged 4 commits into from
Jan 23, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Dec 8, 2023

These dependencies are very large and are irrelevant to the project's core features (to say nothing of the times that the boto3 requirement has sent me into dependency hell).

@AlmightyYakob I would advise releasing this change as a minor version update.

These dependencies are very large and are irrelevant to the project's core
features (to say nothing of the times that the boto3 requirement has sent me
into dependency hell).
@jjnesbitt
Copy link
Member

@jwodder Based on the discussion in dandi/dandi-cli#1371 (comment), I wonder if we should first remove the dependency on zarr (#41), and then rebase this PR to simply make boto3 an extra requirement.

@yarikoptic
Copy link
Member

I think having a walker which we might even reuse in dandi-cli would indeed be useful and remove dependency on zarr. @jjnesbitt would you want to do it or us to do it?

@jjnesbitt
Copy link
Member

I think having a walker which we might even reuse in dandi-cli would indeed be useful and remove dependency on zarr. @jjnesbitt would you want to do it or us to do it?

What you're talking about specifically is removing the use of the zarr package in yield_files_local, and replacing it with a native os.walk implementation.

I think that makes sense, however I think that should be addressed separately. As far as this PR, I'll merge this to take care of the issue at hand. Whenever we remove the zarr dependency, we can bump another minor version.

@jjnesbitt jjnesbitt merged commit decd7a1 into master Jan 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants