fix: orphan packages #10
GitHub Actions / clippy
succeeded
Jan 5, 2024 in 0s
clippy
3 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 3 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.75.0 (82e1608df 2023-12-21)
- cargo 1.75.0 (1d8b05cdd 2023-11-20)
- clippy 0.1.75 (82e1608 2023-12-21)
Annotations
Check warning on line 145 in packages/ntex-helmet/src/lib.rs
github-actions / clippy
this `impl` can be derived
warning: this `impl` can be derived
--> packages/ntex-helmet/src/lib.rs:141:1
|
141 | / impl Default for Helmet {
142 | | fn default() -> Self {
143 | | Self(HelmetCore::default())
144 | | }
145 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it
|
129 + #[derive(Default)]
130 | pub struct Helmet(HelmetCore);
|
Check warning on line 138 in packages/ntex-helmet/src/lib.rs
github-actions / clippy
method `add` can be confused for the standard trait method `std::ops::Add::add`
warning: method `add` can be confused for the standard trait method `std::ops::Add::add`
--> packages/ntex-helmet/src/lib.rs:136:5
|
136 | / pub fn add(self, middleware: impl helmet_core::Header + 'static) -> Self {
137 | | Self(self.0.add(middleware))
138 | | }
| |_____^
|
= help: consider implementing the trait `std::ops::Add` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
= note: `#[warn(clippy::should_implement_trait)]` on by default
Check warning on line 1487 in packages/helmet-core/src/lib.rs
github-actions / clippy
method `add` can be confused for the standard trait method `std::ops::Add::add`
warning: method `add` can be confused for the standard trait method `std::ops::Add::add`
--> packages/helmet-core/src/lib.rs:1484:5
|
1484 | / pub fn add(mut self, header: impl Header + 'static) -> Self {
1485 | | self.headers.push(Box::new(header));
1486 | | self
1487 | | }
| |_____^
|
= help: consider implementing the trait `std::ops::Add` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
= note: `#[warn(clippy::should_implement_trait)]` on by default
Loading