Introduce poetry python package management tool (deprecated) #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Per our discussion on MM, we will
poetry
to manageubuntu-server-netboot
as a python package for the distribution purpose later, and development of test cases.Checklist:
poetry run pytest
locally to ensure all linter checks passSteps to Test This Pull Request
Follow the updated
README
and it should generate the same content ofgrub.cfg
as what its previous codebase does. What the only change a user will be aware of is the command name migrating toubuntu-server-netboot
fromubuntu-server-netboot.py
.Expected behavior
grub.cfg
is the same. No regression ofgrub.cfg
.Related Issue
#18
Additional context
After we land this pull request, I will build the python package and update the README to show how to install
ubuntu-server-netboot
as a python package from PyPI or as a deb package from PPA directly. We will address this issue in more details later.