Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce poetry python package management tool (deprecated) #19

Closed
wants to merge 2 commits into from

Conversation

tai271828
Copy link
Collaborator

Types of changes

  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update

Description

Per our discussion on MM, we will poetry to manage ubuntu-server-netboot as a python package for the distribution purpose later, and development of test cases.

Checklist:

  • Add test cases to all the changes you introduce
  • Run poetry run pytest locally to ensure all linter checks pass
  • Update the documentation if necessary

Steps to Test This Pull Request

Follow the updated README and it should generate the same content of grub.cfg as what its previous codebase does. What the only change a user will be aware of is the command name migrating to ubuntu-server-netboot from ubuntu-server-netboot.py.

Expected behavior

grub.cfg is the same. No regression of grub.cfg.

Related Issue

#18

Additional context

After we land this pull request, I will build the python package and update the README to show how to install ubuntu-server-netboot as a python package from PyPI or as a deb package from PPA directly. We will address this issue in more details later.

@tai271828 tai271828 force-pushed the pr-poetry-python-package branch from fb356ec to fc870de Compare May 6, 2021 08:20
@tai271828 tai271828 force-pushed the pr-poetry-python-package branch from fc870de to f4a5a4c Compare May 6, 2021 08:26
@tai271828
Copy link
Collaborator Author

It seems something wrong with github. Let me create another new pull request to replace this one.

@tai271828 tai271828 closed this May 6, 2021
@tai271828 tai271828 deleted the pr-poetry-python-package branch May 6, 2021 08:28
@tai271828 tai271828 changed the title Introduce poetry python package management tool Introduce poetry python package management tool (deprecated) May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant