Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "{vencord,vesktop}: fonts (#840)" #844

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

lovesegfault
Copy link
Contributor

@lovesegfault lovesegfault commented Feb 9, 2025

This introduced IFD and broke evaluation for flakes users.

This reverts commit be606ea / #840

This introduced IFD and broke evaluation for flakes users.

This reverts commit be606ea.
@Flameopathic
Copy link
Contributor

sorry about that! i'm not familiar with what would cause IFD, was it because of the builtins.readFile?

nix flake check didn't have anything to say, do you know why this wouldn't've been caught by the testbeds?

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not familiar with what would cause IFD, was it because of the builtins.readFile?

I strongly believe so.

nix flake check didn't have anything to say, do you know why this wouldn't've been caught by the testbeds?

I do not know since when this is the case, but IFD is allowed on my NixOS machine although I did not explicitly enable this option:

$ nix config show | grep allow-import-from-derivation
allow-import-from-derivation = true

Maybe the CI installs nix with the same default configuration...

@trueNAHO trueNAHO merged commit e72aa84 into danth:master Feb 9, 2025
53 checks passed
@danth
Copy link
Owner

danth commented Feb 9, 2025

See my suggestion here on a way to do this without builtins.readFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants