DAOS-17718 ddb: UI fix winteh interractive mode

[knard38]

Description

ddb can be start in interactive mode with providing the vos file to open as parameter.
However, other option such as -w or --debug can not be provided as illustrated in the following examples.

[root@wolf-66 tmp]# env PMEMOBJ_CONF="sds.at_create=0" ddb 5b4b931a-356c-4220-96db-12e37c665d54/vos-4
ddb version 2.7.101
ddb:  ls
Listing contents of '/'
CONT: (/[0]) /9e143bc1-61e3-4e58-b0c1-ec7fde63b79f
ddb:  ^D

[root@wolf-66 tmp]# env PMEMOBJ_CONF="sds.at_create=0" ddb -w 5b4b931a-356c-4220-96db-12e37c665d54/vos-4
ddb version 2.7.101
ERROR: -w: unknown command, try 'help'

[root@wolf-66 tmp]# env PMEMOBJ_CONF="sds.at_create=0" ddb --debug 5b4b931a-356c-4220-96db-12e37c665d54/vos-4
DEBUG 2025/02/14 13:11:58.549778 main.go:174: debug output enabled
DEBUG 2025/02/14 13:11:58.550186 main.go:186: Connect to path: 5b4b931a-356c-4220-96db-12e37c665d54/vos-4
ddb version 2.7.101
ERROR: --debug: unknown command, try 'help'

Before requesting gatekeeper:

• Two review approvals and any prior change requests have been resolved.
• Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• Commit messages follows the guidelines outlined here.
• Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• You are the appropriate gatekeeper to be landing the patch.
• The PR has 2 reviews by people familiar with the code, including appropriate owners.
• Githooks were used. If not, request that user install them and check copyright dates.
• Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• All builds have passed. Check non-required builds for any new compiler warnings.
• Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• If applicable, the PR has addressed any potential version compatibility issues.
• Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• Extra checks if forced landing is requested
  • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • No new NLT or valgrind warnings. Check the classic view.
  • Quick-build or Quick-functional is not used.
• Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions]

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-17718

[kjacque]

Do we have any ftests for ddb that could be run against this change with a commit pragma?

The change seems fine for interactive mode, but did you verify it doesn't break non-interactive mode?

[knard38]

Do we have any ftests for ddb that could be run against this change with a commit pragma?

The change seems fine for interactive mode, but did you verify it doesn't break non-interactive mode?

From my understanding, the unit tests src/utils/ddb/tests should check this. There is also the following ftest which are testing ddb:

• https://github.com/daos-stack/daos/blob/master/src/tests/ftest/recovery/ddb.py
• https://github.com/daos-stack/daos/blob/master/src/tests/ftest/recovery/container_list_consolidation.p

Thus I am going to merge with master and restart the CI with running the recovery tests.

[knard38]

Do we have any ftests for ddb that could be run against this change with a commit pragma?
The change seems fine for interactive mode, but did you verify it doesn't break non-interactive mode?

From my understanding, the unit tests src/utils/ddb/tests should check this. There is also the following ftest which are testing ddb:

• https://github.com/daos-stack/daos/blob/master/src/tests/ftest/recovery/ddb.py
• https://github.com/daos-stack/daos/blob/master/src/tests/ftest/recovery/container_list_consolidation.p

Thus I am going to merge with master and restart the CI with running the recovery tests.

Recovery functional tests will be run by the CI with the commit ed1400f

[daosbuild1]

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15911/2/execution/node/1509/log