Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16876 tests: test for invalid DTX entry - b26 #15912

Open
wants to merge 2 commits into
base: release/2.6
Choose a base branch
from
Open

DAOS-16876 tests: test for invalid DTX entry - b26 #15912

wants to merge 2 commits into from

Conversation

Nasf-Fan
Copy link
Contributor

DTX logic should be able to detect and handle invalid DTX entry, such as the one has dangling referenced record.

Add new test case to simulate the case of dirty DTX entry was left on disk after commit.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@Nasf-Fan
DAOS-16876 vos: discard invalid DTX when commit or abort - b26
649a287 
When commit or abort a DTX, we will check whether it is a valid
entry or not. For invalid case, we will discard it with warning
message and increase related metrics counter.

It may be not perfect solution, but it is efficient to help the
user to cleanup system efficiently.

Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Fan Yong <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Ticket title is 'LRZ: m02r01s07dao engine coredumps with vos EMRG src/vos/ilog.c:411 ilog_open() Assertion'
Status is 'In Progress'
Labels: 'ALCF,LRZ,alcf_track,google-cloud-daos,scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16876

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Feb 14, 2025
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15912/3/execution/node/321/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15912/3/execution/node/259/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15912/3/execution/node/281/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15912/3/execution/node/438/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15912/3/execution/node/476/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15912/3/execution/node/343/log

@Nasf-Fan
DAOS-16876 tests: test for invalid DTX entry - b26
79a9765 
DTX logic should be able to detect and handle invalid DTX entry, such
as the one has dangling referenced record.

Add new test case to simulate the case of dirty DTX entry was left on
disk after commit.

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16876_test_b26 branch from 60a2a2d to 79a9765 Compare February 14, 2025 15:54
@Nasf-Fan Nasf-Fan changed the title DAOS-16876 tests: test for handling invalid DTX entry DAOS-16876 tests: test for invalid DTX entry - b26 Feb 14, 2025
@Nasf-Fan Nasf-Fan marked this pull request as ready for review February 16, 2025 02:19
@Nasf-Fan Nasf-Fan requested review from a team as code owners February 16, 2025 02:19
NiuYawei
NiuYawei previously approved these changes Feb 17, 2025
View reviewed changes
Base automatically changed from Nasf-Fan/DAOS-16876_discard_b26 to release/2.6 February 19, 2025 07:02
@gnailzenh gnailzenh dismissed NiuYawei’s stale review February 19, 2025 07:02

The base branch was changed.

@gnailzenh gnailzenh requested review from a team as code owners February 19, 2025 07:02
daltonbohning
daltonbohning reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15912/6/execution/node/1509/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@NiuYawei NiuYawei NiuYawei left review comments

@janekmi janekmi Awaiting requested review from janekmi

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

@jolivier23 jolivier23 Awaiting requested review from jolivier23

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nasf-Fan @daosbuild1 @NiuYawei @daltonbohning