Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16661 common: Integrate PMDK logging system w/ VOS logging system - NLT test. #15948

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

DAOS-16661 common: Integrate PMDK logging system w/ VOS logging system - NLT test. #15948

wants to merge 40 commits into from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Feb 20, 2025

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

grom72 and others added 30 commits September 3, 2024 12:42
@grom72
Integrate PMDK logging system w/ VOS logging system.
149320c 
To enable new message in log in NLT.
Allow-unstable-test: true

Priority: 2

Required-githooks: true

Co-authored-by: Jan Michalski <[email protected]>
Co-authored-by: Tomasz Gromadzki <[email protected]>

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
HARK is reported as INFO
1011420 
To enable new message in log in NLT.
Allow-unstable-test: true

Priority: 2

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix - force build
f9b926d 
Priority: 2

Allow-unstable-test: true
Skip-func-hw-test: false

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Skip NLT tests as they blocks functional validation.
45e6548 
Skip-nlt: true
Priority: 2

Allow-unstable-test: true
Skip-func-hw-test: false

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix: apply git-format-clang chanhes
76fe5c6 
Skip-nlt: true
Priority: 2
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Test: re-run to remove failed Trivy build
a516943 
Skip-nlt: true
Priority: 2
Allow-unstable-test: true

Required-githooks: true
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
224ea5c 
PR-repos: pmdk@PR-42:2

Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556
Allow-unstable-test: true
Priority: 2

Required-githooks: true
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
No error message on intentional pmemobj transaction abort
c445554 
PR-repos: pmdk@PR-43:1

Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556
Allow-unstable-test: true
Priority: 2

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
055c40f 
PR-repos: pmdk@PR-43:2

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix merge
8f2b121 
PR-repos: pmdk@PR-43:2

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix: apply fix for pmem/pmdk#6107
6a85d36 
Annoying error message on user intentional transaction abort.

PR-repos: pmdk@PR-43:2

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
fix: skip NLT tests for full HW validation
c5935f1 
Skip-NLT: true

PR-repos: pmdk@PR-43:2

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
3e73bd5 
Required-githooks: true
@grom72
Fix: apply fix for pmem/pmdk#6126
ec17be3 
Unnecessary warning: "Cannot find any matching device, no bad blocks found" for non-pmem HW

skip NLT tests for full HW validation
Skip-NLT: true

PR-repos: pmdk@PR-43:5

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix: apply final fix for pmem/pmdk#6126
9c1a53e 
Unnecessary warning: "Cannot find any matching device, no bad blocks found" for non-pmem HW

skip NLT tests for full HW validation
Skip-NLT: true

PR-repos: pmdk@PR-43:6

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
4672438 
skip NLT tests for full HW validation
Skip-NLT: true

PR-repos: pmdk@PR-43:7

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-loging
4c0b796 
skip NLT tests for full HW validation
Skip-NLT: true

PR-repos: pmdk@PR-43:7

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Required-githooks: true
Signed-off-by: Gromadzki, Tomasz <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
a7ad9fa 
skip NLT tests for full HW validation
Skip-NLT: true

PR-repos: pmdk@PR-43:11

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2
@grom72
Update copyright info
bd924f6 
skip NLT tests for full HW validation
Skip-NLT: true

PR-repos: pmdk@PR-43:11

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
f1e6c21 
Skip NLT tests for full HW validation
Skip-NLT: true

PR-repos: pmdk@PR-43:19

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
7beccb8 
Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
@jolivier23 @grom72
Optimizing the use of the DD_FLAG() macro
1d3f89a 
Co-authored-by: Jeff Olivier <[email protected]>
Co-authored-by: Tomasz Gromadzki <[email protected]>

Signed-off-by: Tomasz Gromadzki <[email protected]>
@jolivier23 @grom72
pmdk_log_function optimization
13dd692 
pmdk_log_function optimization based on _D_DEBUG_EXPANDED macro.

Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260
Allow-unstable-test: true
Priority: 2

Co-authored-by: Jeff Olivier <[email protected]>
Co-authored-by: Tomasz Gromadzki <[email protected]>

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Unified parameters naming convention
2b2b30c 
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
pmemobj log to daos translation tab optimization
303a42d 
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
ce9fa93 
Cancel-prev-build: false

Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260
Allow-unstable-test: true
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
a20d8b5 
Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260
Allow-unstable-test: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Merge remote-tracking branch 'origin/master' into grom72/pmdk-w-logging
c252552 
Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260
Allow-unstable-test: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix pmemobj build in dtx and ddb tests
b0a42ff 
pmemobj dependency is required for proper build of dtx and ddb tests.

Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260
Allow-unstable-test: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix - remove unrelated entries from changelog
fe3243d 
Doc-only: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix: NLT tests run on non-pmem
3aa45a0 
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-test: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@github-actions GitHub Actions
Copy link

Ticket title is 'Integrate PMDK logging system w/ VOS logging system.'
Status is 'In Review'
Labels: 'scrubbed_2.8,test_2.8'
Errors are Title of PR is too long
https://daosio.atlassian.net/browse/DAOS-16661

@grom72
Tests: NLT tests with quotation marks
47fe6dd 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-test: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Signed-off-by: Tomasz Gromadzki <[email protected]
@grom72
Revert "Tests: NLT tests with quotation marks"
47ca9d0 
This reverts commit 47fe6dd.

Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-test: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Tests: NLT failure blocks other tests
81fd2b2 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true

Skip-build-leap15-icc: true

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Tests: Let's try to suppress non-PMem warning in NLT
7567f53 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Skip-func-test-vm-all: true
Skip-func-test-hw: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 force-pushed the grom72/pmdk-w-logging-test branch from f11a920 to 7567f53 Compare February 21, 2025 08:27
@grom72
Test w/o NLT stage
2d3a1c6 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true
Skip-NLT: true

Skip-func-test-vm-all: true
Skip-func-test-hw: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 force-pushed the grom72/pmdk-w-logging-test branch from be5e70b to 2d3a1c6 Compare February 21, 2025 09:48
@grom72
Tests: Let's try to bypass qualityGate in NLT
f693ccb 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Skip-func-test-vm-all: true
Skip-func-test-hw: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 force-pushed the grom72/pmdk-w-logging-test branch from 613a53c to f693ccb Compare February 21, 2025 18:51
@grom72
Tests: Let's try to bypass qualityGate in NLT
918a0a2 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Skip-func-test-vm-all: true
Skip-func-test-hw: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Tests: Let's try to bypass NLT error
40d340c 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Skip-func-test-vm-all: true
Skip-func-test-hw: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Tests: Let's try to bypass NLT w/ short name
13d01c2 
Cancel-prev-build: false
Parallel-build: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-build-el8-gcc-dev: true

Skip-build-leap15-icc: true

Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-bullseye: true

Skip-func-test-vm-all: true
Skip-func-test-hw: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grom72 @jolivier23