Adding license text file to the spec #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damokm4
force-pushed
the
adding-license-text-file
branch
from
c5500dc to
68ac481
Compare
Signed-off-by: Dariusz M <[email protected]>
damokm4
force-pushed
the
adding-license-text-file
branch
from
68ac481 to
7d213ce
Compare
There was a problem hiding this comment.
Thanks for the submission. It's truly appreciated.
Generally speaking, any .spec file change should bump the Release: value (or reset it to
1 if updating to a newer version) and add a %changelog entry.
But you don't really need to do that here as this PR cannot be landed to our repo as it cannot be tested before landing due to security requirements and Jenkins inability to compy with them. Hopefully this can change in the future when we move to GitHub Actions.
I will have to incorporate these changes into an internally generated PR that can run our CI to validate the change before landing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.