Fixing goavro bug due to codec state mutation #4070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized why this problem existed prior to 2.12 but never manifested in our code until 1.16. This is because the old code was always creating a new codec when serializing (since it had to create a FullStandardJson codec). After the 1.16 change, it was reusing the schema.Codec() which would be subject to mutation issues... For now, bringing back to old approach that always creates a new codec, which should get rid of the mutation issue altogether... Signed-off-by: Patrick Assuied <[email protected]>
passuied
changed the title
Signed-off-by: Patrick Assuied <[email protected]>
JoshVanL
previously approved these changes
Oct 22, 2025
|
As discussed on the call this is less of a workaround and more of a revert in behaviour to the old 1.15 behaviour. |
sicoyle
previously approved these changes
Oct 22, 2025
Upgrade to latest srclient library as well (small [patch](riferrei/srclient#114)) Added unit test to verify goavro error stays fixed Signed-off-by: Patrick Assuied <[email protected]>
passuied
changed the title
JoshVanL
approved these changes
Oct 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #4070 +/- ##
================================================
- Coverage 28.57% 28.57% -0.01%
================================================
Files 333 334 +1
Lines 42113 42175 +62
================================================
+ Hits 12034 12050 +16
- Misses 29076 29121 +45
- Partials 1003 1004 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cicoyle
approved these changes
Oct 22, 2025
passuied
added a commit
to passuied/components-contrib
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Patrick Assuied <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing goavro bug due to codec state mutation (linkedin/goavro#299).
Also taking a more defensive approach moving forward, bringing back the old approach that always creates a new codec, which should get rid of the mutation issue altogether in the future...
Added unit test to verify it's fixed
Issue reference
#4067
linkedin/goavro#299
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.