-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace [Obsolete] with [Experimental] attributes #1487
base: release-1.16
Are you sure you want to change the base?
Conversation
…quiresPreviewFeatures] attribute where relevant Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@philliphoff It looks like
I haven't been able to identify any other attributes that quite flag a warning like To that end, I propose we keep |
[Experimental] similarly requires an analyzer ID be provided as it does something with code analyzers. @WhitWaldo The guidance says I would still suggest a switch to |
I'll give it a shot and see what happens! |
…ntal] instead Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Description
There are some places where it makes sense to mark things as
[Obsolete]
, but it'd be nice to reserve that attribute only for those places where something is truly obsolete and not recommended as a path going forward. It's all we've had to date to mark non-stable functionality, but with the shift to .NET 8 as the minimal version, this brings with it two new attributes:[Experimental]
and[RequiresPreviewFeatures]
.Unfortunately,
[Experimental]
seems to have something to do with code analyzers as it has a required string argument for the analyzer ID, so because I'm not entirely sure what this entails for the downstream user experience, I'm skipping over it.Rather, I've replaced the pre-stable functionality previously marked with
[Obsolete]
with[RequiresPreviewFeatures]
and retained the original message text, e.g.[RequiresPreviewFeatures("The API is currently not stable as it is in the Alpha stage. This attribute will be removed once it is stable.")]
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1219
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: